Re: [PATCH v4 07/11] station: roam blacklist BSS's, and consider when roaming

Hi James,

On 3/28/25 9:42 AM, James Prestwood wrote:
> If the BSS is requesting IWD roam elsewhere add this BSS to the
> blacklist using BLACKLIST_REASON_ROAM_REQUESTED. This will lower
> the chances of IWD roaming/connecting back to this BSS in the
> future.
> 
> This then allows IWD to consider this blacklist state when picking
> a roam candidate. Its undesireable to fully ban a roam blacklisted
> BSS, so some additional sorting logic has been added. Prior to
> comparing based on rank, BSS's will be sorted into two higher level
> groups:
> 
> Above Threshold - BSS is above the CriticalRoamThreshold
> Below Threshold - BSS is below the CriticalRoamThreshold

As discussed, I amended this to read RoamThreshold since that is what patch 6 is 
returning.

> 
> Within each of these groups the BSS may be roam blacklisted which
> will position it at the bottom of the list within its respecitve
> group.
> ---
>   src/station.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++-----
>   1 file changed, 69 insertions(+), 6 deletions(-)
> 

<snip>

> + *
> + * For an initial (probably naive) approach here we can use the
> + * CriticalSignalThreshod[5G] which indicates the signal level that would not

ditto here.

> + * be of an acceptable connection quality. BSS can then be sorted either
> + * above or below this threshold. Within each of these groups a BSS may be
> + * blacklisted, meaning it should get sorted lower on the list compared to
> + * others within the same group.
> + *

All applied, thanks.

Regards,
-Denis