Re: [PATCH] station: fix setting an empty affinities list
Denis Kenzior <[email protected]> Wed, 23 Apr 2025 09:43:15 -0500
| Newsgroups | dev.linux.lists.iwd |
|---|---|
| Message-ID | <[email protected]> |
Hi James, On 4/17/25 11:16 AM, James Prestwood wrote: > A prior patch broke this by checking the return of > l_dbus_message_iter_next_entry. This was really subtle but the logic > actually relied on _not_ checking that return in order to handle > empty lists. > > Instead of reverting the logic was adapted/commented to make it more > clear what the API expects from DBus. If list contains at least one > value the first element path will get set, if it contains zero > values "new_path" will be set to NULL which will then cause the > list to be cleared later on. > > This both fixes the regression, and makes it clear that a zero > element list is supported and handled. > --- > src/station.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > Applied, thanks. Regards, -Denis