Re: [PATCH] wiphy: check if ht_capabilities are actually set

Paul Menzel <[email protected]> Fri, 26 Dec 2025 10:02:26 +0500
Newsgroups dev.linux.lists.iwd
Message-ID <[email protected]>
Dear Berend,


Thank you for your patch.

Am 25.12.25 um 23:26 schrieb berend:
> commit 928fba083c87147603702907940d7c263e62e4dd (HEAD -> master)
> Author: Berend De Schouwer <[email protected]>
> Date:   Thu Dec 25 17:31:49 2025 +0200
> 
>      wiphy: check if ht_capabilities are actually set
>      
>      Some devices set HT, but only provide HT20.  When this is true,
>      ap_validate_band_channel() will succeed with 40MHz width, but the
>      device will refuse to start an AP.

It’d be great if you documented one of those devices in the commit message.

> 
> diff --git a/src/wiphy.c b/src/wiphy.c
> index b6774f69..85e31cf1 100644
> --- a/src/wiphy.c
> +++ b/src/wiphy.c

[…]

It looks like you pasted the output of `git show` into the message. That 
format is harder to apply with the git tools. Could you please resend 
with `git send-email` which uses the output of `git format-patch`.


Kind regards,

Paul