Re: [PATCH] wiphy: check if ht_capabilities are actually set

berend <[email protected]> Sat, 27 Dec 2025 05:01:14 +0000
Newsgroups	dev.linux.lists.iwd
Message-ID	<[email protected]>
On Fri, 2025-12-26 at 10:02 +0500, Paul Menzel wrote:
> It’d be great if you documented one of those devices in the commit
> message.

Done.

> > 
> > diff --git a/src/wiphy.c b/src/wiphy.c
> > index b6774f69..85e31cf1 100644
> > --- a/src/wiphy.c
> > +++ b/src/wiphy.c
> 
> […]
> 
> It looks like you pasted the output of `git show` into the message.
> That
> format is harder to apply with the git tools. Could you please resend
> with `git send-email` which uses the output of `git format-patch`.

Done.

I don't know if it's a hardware or firmware limitation on a Raspberry
Pi.  The HT capabilities did change with the firmware versions, but the
40MHz channels never actually worked.

Old firmware:

2.4GHz Band
        Bitrates (non-HT)
                 1.0 Mbps
                 2.0 Mbps
                 5.5 Mbps
                11.0 Mbps
                 6.0 Mbps
                 9.0 Mbps
                12.0 Mbps
                18.0 Mbps
                24.0 Mbps
                36.0 Mbps
                48.0 Mbps
                54.0 Mbps
        HT Capabilities
                HT40
                Short GI for 20Mhz
                Short GI for 40Mhz
        HT RX MCS indexes
                0-7


New firmware:

2.4GHz Band
        Bitrates (non-HT)
                 1.0 Mbps
                 2.0 Mbps
                 5.5 Mbps
                11.0 Mbps
                 6.0 Mbps
                 9.0 Mbps
                12.0 Mbps
                18.0 Mbps
                24.0 Mbps
                36.0 Mbps
                48.0 Mbps
                54.0 Mbps
        HT Capabilities
                HT20
                Short GI for 20Mhz
        HT RX MCS indexes
                0-7


$ iw list:

Wiphy phy1
	wiphy index: 1
	max # scan SSIDs: 10
	max scan IEs length: 2048 bytes
	max # sched scan SSIDs: 16
	max # match sets: 16
	Retry short limit: 7
	Retry long limit: 4
	Coverage class: 0 (up to 0m)
	Supported Ciphers:
		* WEP40 (00-0f-ac:1)
		* WEP104 (00-0f-ac:5)
		* TKIP (00-0f-ac:2)
		* CCMP-128 (00-0f-ac:4)
		* CMAC (00-0f-ac:6)
	Available Antennas: TX 0 RX 0
	Supported interface modes:
		 * IBSS
		 * managed
		 * AP
		 * P2P-client
		 * P2P-GO
		 * P2P-device
	Band 1:
		Capabilities: 0x1020
			HT20
			Static SM Power Save
			RX HT20 SGI
			No RX STBC
			Max AMSDU length: 3839 bytes
			DSSS/CCK HT40
		Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
		Minimum RX AMPDU time spacing: 16 usec (0x07)
		HT TX/RX MCS rate indexes supported: 0-7
		Bitrates (non-HT):
			* 1.0 Mbps
			* 2.0 Mbps (short preamble supported)
			* 5.5 Mbps (short preamble supported)
			* 11.0 Mbps (short preamble supported)
			* 6.0 Mbps
			* 9.0 Mbps
			* 12.0 Mbps
			* 18.0 Mbps
			* 24.0 Mbps
			* 36.0 Mbps
			* 48.0 Mbps
			* 54.0 Mbps
		Frequencies:
			* 2412.0 MHz [1] (20.0 dBm)
			* 2417.0 MHz [2] (20.0 dBm)
			* 2422.0 MHz [3] (20.0 dBm)
			* 2427.0 MHz [4] (20.0 dBm)
			* 2432.0 MHz [5] (20.0 dBm)
			* 2437.0 MHz [6] (20.0 dBm)
			* 2442.0 MHz [7] (20.0 dBm)
			* 2447.0 MHz [8] (20.0 dBm)
			* 2452.0 MHz [9] (20.0 dBm)
			* 2457.0 MHz [10] (20.0 dBm)
			* 2462.0 MHz [11] (20.0 dBm)
			* 2467.0 MHz [12] (20.0 dBm)
			* 2472.0 MHz [13] (20.0 dBm)
			* 2484.0 MHz [14] (disabled)
	Band 2:
		Capabilities: 0x1062
			HT20/HT40
			Static SM Power Save
			RX HT20 SGI
			RX HT40 SGI
			No RX STBC
			Max AMSDU length: 3839 bytes
			DSSS/CCK HT40
		Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
		Minimum RX AMPDU time spacing: 16 usec (0x07)
		HT TX/RX MCS rate indexes supported: 0-7
		VHT Capabilities (0x00001020):
			Max MPDU length: 3895
			Supported Channel Width: neither 160 nor 80+80
			short GI (80 MHz)
			SU Beamformee
		VHT RX MCS set:
			1 streams: MCS 0-9
			2 streams: not supported
			3 streams: not supported
			4 streams: not supported
			5 streams: not supported
			6 streams: not supported
			7 streams: not supported
			8 streams: not supported
		VHT RX highest supported: 0 Mbps
		VHT TX MCS set:
			1 streams: MCS 0-9
			2 streams: not supported
			3 streams: not supported
			4 streams: not supported
			5 streams: not supported
			6 streams: not supported
			7 streams: not supported
			8 streams: not supported
		VHT TX highest supported: 0 Mbps
		VHT extended NSS: not supported
		Bitrates (non-HT):
			* 6.0 Mbps
			* 9.0 Mbps
			* 12.0 Mbps
			* 18.0 Mbps
			* 24.0 Mbps
			* 36.0 Mbps
			* 48.0 Mbps
			* 54.0 Mbps
		Frequencies:
			* 5170.0 MHz [34] (20.0 dBm)
			* 5180.0 MHz [36] (20.0 dBm)
			* 5190.0 MHz [38] (20.0 dBm)
			* 5200.0 MHz [40] (20.0 dBm)
			* 5210.0 MHz [42] (20.0 dBm)
			* 5220.0 MHz [44] (20.0 dBm)
			* 5230.0 MHz [46] (20.0 dBm)
			* 5240.0 MHz [48] (20.0 dBm)
			* 5260.0 MHz [52] (20.0 dBm) (radar detection)
			* 5280.0 MHz [56] (20.0 dBm) (radar detection)
			* 5300.0 MHz [60] (20.0 dBm) (radar detection)
			* 5320.0 MHz [64] (20.0 dBm) (radar detection)
			* 5500.0 MHz [100] (20.0 dBm) (radar
detection)
			* 5520.0 MHz [104] (20.0 dBm) (radar
detection)
			* 5540.0 MHz [108] (20.0 dBm) (radar
detection)
			* 5560.0 MHz [112] (20.0 dBm) (radar
detection)
			* 5580.0 MHz [116] (20.0 dBm) (radar
detection)
			* 5600.0 MHz [120] (20.0 dBm) (radar
detection)
			* 5620.0 MHz [124] (20.0 dBm) (radar
detection)
			* 5640.0 MHz [128] (20.0 dBm) (radar
detection)
			* 5660.0 MHz [132] (20.0 dBm) (radar
detection)
			* 5680.0 MHz [136] (20.0 dBm) (radar
detection)
			* 5700.0 MHz [140] (20.0 dBm) (radar
detection)
			* 5720.0 MHz [144] (13.0 dBm) (radar
detection)
			* 5745.0 MHz [149] (13.0 dBm)
			* 5765.0 MHz [153] (13.0 dBm)
			* 5785.0 MHz [157] (13.0 dBm)
			* 5805.0 MHz [161] (13.0 dBm)
			* 5825.0 MHz [165] (13.0 dBm)
	Supported commands:
		 * new_interface
		 * set_interface
		 * new_key
		 * start_ap
		 * join_ibss
		 * set_pmksa
		 * del_pmksa
		 * flush_pmksa
		 * remain_on_channel
		 * frame
		 * set_wiphy_netns
		 * set_channel
		 * start_sched_scan
		 * start_p2p_device
		 * connect
		 * disconnect
		 * crit_protocol_start
		 * crit_protocol_stop
	software interface modes (can always be added):
	valid interface combinations:
		 * #{ managed } <= 2, #{ P2P-device } <= 1, #{ P2P-
client, P2P-GO } <= 1,
		   total <= 3, #channels <= 2
		 * #{ managed } <= 1, #{ AP } <= 1, #{ P2P-client } <=
1, #{ P2P-device } <= 1,
		   total <= 4, #channels <= 1
	Device supports SAE with AUTHENTICATE command
	Device supports scan flush.
	Device supports randomizing MAC-addr in sched scans.
	max # scan plans: 1
	max scan plan interval: 508
	max scan plan iterations: 0
	Supported TX frame types:
		 * managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70
0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70
0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70
0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
		 * P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70
0x80 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
	Supported RX frame types:
		 * managed: 0x40 0xb0 0xd0
		 * AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
		 * P2P-client: 0x40 0xd0
		 * P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
		 * P2P-device: 0x40 0xd0
	Supported extended features:
		* [ CQM_RSSI_LIST ]: multiple CQM_RSSI_THOLD records
		* [ DFS_OFFLOAD ]: DFS offload
publickey - Berend De Schouwer - 0x128CD671.asc (application/pgp-keys, 3.1 KB)
signature.asc (application/pgp-signature, 928 B)