Re: [kbd] [PATCH 5/5] Replace error() by fprintf() and perror()
Alexey Gladkov <[email protected]> Tue, 12 May 2015 01:00:45 +0300
| Newsgroups | dev.linux.lists.kbd |
|---|---|
| Message-ID | <[email protected]> |
06.05.2015 22:34, Felix Janda пишет: > Alexey Gladkov wrote: >> I prefer to save compatibility with the error() function. It costs >> nothing, but it does not require to keep in mind the difference >> between two implementations. > > There is a small cost (which might not be relevant for kbd): > The compiler does not know that kbd_error() will not return in most > cases and might emit warnings about possibly uninitialized variables > because of that. > > Just to mentoin it... Agree. There is no reason to keep this compatibility right now. -- Rgrds, legion