Re: [kbd] [patchv2 1/3] VT: Add height parameter to con_font_get/set consw operations
Greg Kroah-Hartman <[email protected]> Thu, 19 Jan 2023 16:09:10 +0100
| Newsgroups | dev.linux.lists.kbd,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <Y8ldFjz7d6/[email protected]> |
On Sun, Dec 18, 2022 at 01:32:10AM +0100, Samuel Thibault wrote: > The current con_font_get/set API currently hardcodes a 32-pixel-tall > limitation, which only dates from the old VGA hardware which could not > handle taller fonts than that. > > This change just adds a vpitch parameter to release this > constraint. Drivers which do not support vpitch != 32 can just return > EINVAL when it is not 32, font loading tools will revert to trying 32 > and succeed. > > This change makes the fbcon driver consider vpitch appropriately, thus > making it able to load large fonts. > > Signed-off-by: Samuel Thibault <[email protected]> > > --- > V1 -> V2: Drop (bogus) sisusb_con.c change, it is being phased out > > Index: linux-6.0/drivers/tty/vt/vt.c 6.0 was really old when you sent this, and because of that: > Index: linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c > =================================================================== This file is not even in the tree anymore. Can you rebase this against 6.2-rc4 and resubmit it so that I can apply it? As-is, it will not apply at all :( thanks, greg k-h