Re: [PATCH v2] Update Colemak-DH keymaps with upstream changes

On Sat, Sep 28, 2024 at 11:29:34AM +1000, Callum Andrew wrote:
> - Make Wide Mod mappings consistent with specification

Don't mix file modifications and file renaming.

> - Rename from mod-dh (the name of the project) to colemak-dh (the name
>   of the layout)

This renaming looks useless to me. The "colemak" is already present in
the path. You can always do that:

  loadkeys colemak/mod-dh-ansi-us

in the same way as

  loadkeys qwerty/cz

This is how keymaps search has been working for a very long time.
Duplicating the architecture, keymaps family, and everything else (in most
cases) but the language is bad practice.

I can understand why the author of colemak keymaps named them that in his
standalone project. But in kbd such naming does not seem correct to me.

> Signed-off-by: Callum Andrew <[email protected]>
> ---
>  ...-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} | 0
>  ...-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} | 4 ++--
>  ...od-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} | 0
>  ...od-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} | 4 ++--
>  .../{mod-dh-ansi-us.map => colemak-dh-ansi-us.map}        | 0
>  ...{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} | 8 ++++----
>  .../colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map}  | 0
>  ...{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} | 8 ++++----
>  .../colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map}  | 0
>  .../{mod-dh-matrix-us.map => colemak-dh-matrix-us.map}    | 0
>  10 files changed, 12 insertions(+), 12 deletions(-)
>  rename data/keymaps/i386/colemak/{mod-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} (100%)
>  rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} (97%)
>  rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} (100%)
>  rename data/keymaps/i386/colemak/{mod-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} (97%)
>  rename data/keymaps/i386/colemak/{mod-dh-ansi-us.map => colemak-dh-ansi-us.map} (100%)
>  rename data/keymaps/i386/colemak/{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} (94%)
>  rename data/keymaps/i386/colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map} (100%)
>  rename data/keymaps/i386/colemak/{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} (94%)
>  rename data/keymaps/i386/colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map} (100%)
>  rename data/keymaps/i386/colemak/{mod-dh-matrix-us.map => colemak-dh-matrix-us.map} (100%)

-- 
Rgrds, legion