[PATCH 2/4] kbdfile: remove redundant NULL check in findfile_by_fullname

Krdyan Areg <[email protected]> Sat, 14 Feb 2026 20:27:31 +0300
Newsgroups dev.linux.lists.kbd
Message-ID <[email protected]>
The loop condition suffixes[i] already ensures that suffixes[i] is non-NULL at each iteration.
The inner NULL check is dead code and can never be executed.

Signed-off-by: Krdyan Areg <[email protected]>
---
 src/libkbdfile/kbdfile.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/libkbdfile/kbdfile.c b/src/libkbdfile/kbdfile.c
index 5b1ee6d..2e6347f 100644
--- a/src/libkbdfile/kbdfile.c
+++ b/src/libkbdfile/kbdfile.c
@@ -280,9 +280,6 @@ findfile_by_fullname(const char *fnam, const char *const *suffixes, struct kbdfi
 	fp->flags &= ~KBDFILE_COMPRESSED;
 
 	for (i = 0; suffixes[i]; i++) {
-		if (suffixes[i] == NULL)
-			continue; /* we tried it already */
-
 		if (kbdfile_pathname_sprintf(fp, "%s%s", fnam, suffixes[i]) < 0)
 			continue;
 
-- 
2.52.0