Re: [PATCH 1/2] gen_hosts: refactor monolithic hosts.j2 template into per-workflow templates

On Fri, Aug 29, 2025 at 03:31:01AM -0700, Luis Chamberlain wrote:
> @@ -67,6 +83,7 @@
>    when:
>      - bootlinux_builder
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file
>    tags: ["hosts"]
> @@ -80,6 +97,7 @@
>      - not kdevops_workflows_dedicated_workflow
>      - ansible_hosts_template.stat.exists
>      - not kdevops_enable_nixos|default(false)|bool
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file for NixOS
>    tags: ['hosts']
> @@ -93,6 +111,7 @@
>      - not kdevops_workflows_dedicated_workflow
>      - ansible_hosts_template.stat.exists
>      - kdevops_enable_nixos|default(false)|bool
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Update Ansible inventory access modification time so make sees it updated
>    ansible.builtin.file:
> @@ -112,6 +131,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_cxl
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file for dedicated pynfs work
>    tags: ["hosts"]
> @@ -125,6 +145,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_pynfs
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file for dedicated gitr workflow
>    tags: ["hosts"]
> @@ -140,6 +161,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_gitr
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate an Ansible inventory file for a dedicated ltp workflow
>    tags: ["hosts"]
> @@ -155,6 +177,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_ltp
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file for dedicated nfstest workflow
>    tags: ["hosts"]
> @@ -170,6 +193,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_nfstest
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Set empty enabled test types list for fstests
>    tags: ["hosts"]
> @@ -178,6 +202,7 @@
>    when:
>      - is_fstests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Check which fstests test types are enabled
>    register: fstests_enabled_test_types_reg
> @@ -202,6 +227,7 @@
>    when:
>      - is_fstests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Now expand the list of enabled fstests for valid configuration sections
>    tags: ["hosts"]
> @@ -213,6 +239,7 @@
>    when:
>      - is_fstests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>      - item.changed
>  
>  - name: Generate the Ansible inventory file for a dedicated fstests setup
> @@ -233,6 +260,7 @@
>    when:
>      - is_fstests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Infer enabled blktests test section types
>    ansible.builtin.set_fact:
> @@ -247,6 +275,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_blktests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Debug inferring block test types
>    ansible.builtin.debug:
> @@ -269,6 +298,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_blktests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Infer enabled selftests test section types
>    ansible.builtin.set_fact:
> @@ -283,6 +313,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_selftests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible inventory file for a dedicated selftests setup
>    tags: ["hosts"]
> @@ -296,6 +327,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_selftests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Collect dynamically supported filesystems
>    vars:
> @@ -338,6 +370,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_sysbench
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  
>  - name: Generate the Ansible hosts file for a dedicated fio-tests setup
> @@ -354,6 +387,7 @@
>      - kdevops_workflow_enable_fio_tests
>      - ansible_hosts_template.stat.exists
>      - not kdevops_enable_nixos|default(false)|bool
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  
>  - name: Infer enabled mmtests test types
> @@ -369,6 +403,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_mmtests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible hosts file for a dedicated mmtests setup
>    tags: ["hosts"]
> @@ -382,6 +417,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - kdevops_workflow_enable_mmtests
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Generate the Ansible hosts file for a dedicated reboot-limit setup
>    tags: ["hosts"]
> @@ -395,6 +431,7 @@
>      - kdevops_workflows_dedicated_workflow
>      - workflows_reboot_limit
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  
>  - name: Load AI nodes configuration for multi-filesystem setup
>    include_vars:
> @@ -426,8 +463,9 @@
>      mode: '0644'
>    when:
>      - kdevops_workflows_dedicated_workflow
> -    - kdevops_workflow_enable_ai
> +    - kdevops_workflow_enable_ai|default(false)|bool
>      - ansible_hosts_template.stat.exists
> +    - not kdevops_use_declared_hosts|default(false)|bool
>  

Sorry, these hunks should have been part of the second patch.

 Luis