Re: [PATCH v2 23/37] guestfs: Don't run the 'destroy' tags on the controller

Daniel Gomez <[email protected]>
Newsgroups dev.linux.lists.kdevops
Organization kernel.org
Message-ID <[email protected]>
On 02/09/2025 15.54, Chuck Lever wrote:
> From: Chuck Lever <[email protected]>
> 
> "make destroy" was skipping some important file removals, and
> removing other files that do not exist.
> 
> Reviewed-by: Luis Chamberlain <[email protected]>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
>  scripts/guestfs.Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile
> index f6c350a43f27..953c61493a88 100644
> --- a/scripts/guestfs.Makefile
> +++ b/scripts/guestfs.Makefile
> @@ -96,6 +96,7 @@ PHONY += status_guestfs
>  
>  destroy_guestfs:
>  	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
> +		--limit 'baseline:dev:service' \

Do we need to be explicit here?

The guestfs.yml playbook already defines hosts: all. Not sure if I understand
the reason why things were skipped. Can you elaborate?

>		playbooks/guestfs.yml \
>  		--extra-vars=@./extra_vars.yaml \
>  		--tags destroy
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.