[PATCH 09/10] playbooks: ansible-lint fix jinja[spacing]
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- playbooks/mmtests-compare.yml | 2 +- playbooks/roles/ai_docker_storage/tasks/main.yml | 2 +- playbooks/roles/ai_milvus_storage/tasks/main.yml | 2 +- .../roles/blktests/tasks/install-deps/main.yml | 6 +- playbooks/roles/bootlinux/tasks/main.yml | 2 +- .../roles/bootlinux/tasks/update-grub/install.yml | 4 +- .../roles/bootlinux/tasks/update-grub/main.yml | 6 +- .../roles/btrfs_progs/tasks/install-deps/main.yml | 6 +- playbooks/roles/btrfs_progs/tasks/main.yml | 4 +- .../roles/build_qemu/tasks/install-deps/main.yml | 6 +- .../compile_dbench/tasks/install-deps/main.yml | 2 +- .../create_partition/tasks/install-deps/main.yml | 6 +- playbooks/roles/cxl/tasks/install-deps/main.yml | 6 +- playbooks/roles/devconfig/tasks/main.yml | 4 +- .../fstests/tasks/install-deps/debian/main.yml | 2 +- .../roles/fstests/tasks/install-deps/main.yml | 6 +- .../fstests/tasks/install-deps/redhat/main.yml | 2 +- playbooks/roles/fstests/tasks/main.yml | 12 ++-- .../tasks/install-deps/main.yml | 6 +- playbooks/roles/gen_nodes/tasks/main.yml | 4 +- playbooks/roles/gitr/tasks/main.yml | 8 +-- .../tasks/install-deps/main.yml | 6 +- .../tasks/install-deps/main.yml | 6 +- .../tasks/install-deps/main.yml | 6 +- .../install_terraform/tasks/install-deps/main.yml | 6 +- playbooks/roles/ktls/tasks/install-deps/main.yml | 6 +- .../libvirt_user/tasks/enable-user/debian/main.yml | 2 +- .../libvirt_user/tasks/enable-user/redhat/main.yml | 2 +- .../libvirt_user/tasks/enable-user/suse/main.yml | 2 +- .../roles/libvirt_user/tasks/install-deps/main.yml | 6 +- playbooks/roles/minio_warp_run/tasks/main.yml | 2 +- .../roles/mmtests/tasks/install-deps/main.yml | 6 +- playbooks/roles/mmtests_compare/tasks/main.yml | 34 +++++------ playbooks/roles/monitoring/tasks/monitor_run.yml | 2 +- .../roles/nfsd/tasks/install-deps/debian/main.yml | 2 +- .../roles/nfsd/tasks/install-deps/suse/main.yml | 2 +- playbooks/roles/pkg/tasks/main.yml | 2 +- playbooks/roles/pynfs/tasks/install-deps/main.yml | 6 +- .../roles/reboot-limit/tasks/install-deps/main.yml | 6 +- playbooks/roles/reboot-limit/tasks/main.yml | 22 +++---- .../roles/selftests/tasks/install-deps/main.yml | 6 +- playbooks/roles/selftests/tasks/main.yml | 6 +- playbooks/roles/steady_state/tasks/main.yaml | 24 ++++---- .../sysbench/tasks/install-deps/debian/main.yml | 10 ++-- .../roles/sysbench/tasks/install-deps/main.yml | 6 +- .../roles/sysbench/tasks/mysql-docker/main.yaml | 70 +++++++++++----------- 46 files changed, 173 insertions(+), 173 deletions(-) diff --git a/playbooks/mmtests-compare.yml b/playbooks/mmtests-compare.yml index 7e948672..56765259 100644 --- a/playbooks/mmtests-compare.yml +++ b/playbooks/mmtests-compare.yml @@ -2,4 +2,4 @@ - hosts: localhost roles: - role: mmtests_compare - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool diff --git a/playbooks/roles/ai_docker_storage/tasks/main.yml b/playbooks/roles/ai_docker_storage/tasks/main.yml index c97775e1..8720eb0b 100644 --- a/playbooks/roles/ai_docker_storage/tasks/main.yml +++ b/playbooks/roles/ai_docker_storage/tasks/main.yml @@ -7,7 +7,7 @@ tags: vars - name: Docker storage setup - when: ai_docker_storage_enable|bool + when: ai_docker_storage_enable | bool block: - name: Install filesystem utilities ansible.builtin.package: diff --git a/playbooks/roles/ai_milvus_storage/tasks/main.yml b/playbooks/roles/ai_milvus_storage/tasks/main.yml index d2b21906..4eaf03ff 100644 --- a/playbooks/roles/ai_milvus_storage/tasks/main.yml +++ b/playbooks/roles/ai_milvus_storage/tasks/main.yml @@ -7,7 +7,7 @@ tags: vars - name: Milvus storage setup - when: ai_milvus_storage_enable|bool + when: ai_milvus_storage_enable | bool block: - name: Install filesystem utilities ansible.builtin.package: diff --git a/playbooks/roles/blktests/tasks/install-deps/main.yml b/playbooks/roles/blktests/tasks/install-deps/main.yml index bdc3de4c..786d0144 100644 --- a/playbooks/roles/blktests/tasks/install-deps/main.yml +++ b/playbooks/roles/blktests/tasks/install-deps/main.yml @@ -5,8 +5,8 @@ # tasks to install dependencies for oscheck - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/bootlinux/tasks/main.yml b/playbooks/roles/bootlinux/tasks/main.yml index f453caf6..a2e2770e 100644 --- a/playbooks/roles/bootlinux/tasks/main.yml +++ b/playbooks/roles/bootlinux/tasks/main.yml @@ -302,7 +302,7 @@ regexp: "^DEFAULTDEBUG=" line: DEFAULTDEBUG=yes tags: ["saved"] - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' - name: Install packages on each target node ansible.builtin.import_tasks: diff --git a/playbooks/roles/bootlinux/tasks/update-grub/install.yml b/playbooks/roles/bootlinux/tasks/update-grub/install.yml index 9540480d..209dbd7c 100644 --- a/playbooks/roles/bootlinux/tasks/update-grub/install.yml +++ b/playbooks/roles/bootlinux/tasks/update-grub/install.yml @@ -205,12 +205,12 @@ - name: Obtain command to set default kernel to boot ansible.builtin.set_fact: grub_set_default_boot_kernel: grub-set-default - when: ansible_facts['os_family']|lower != 'redhat' or ansible_facts['distribution_major_version'] | int < 8 + when: ansible_facts['os_family'] | lower != 'redhat' or ansible_facts['distribution_major_version'] | int < 8 - name: Obtain command to set default kernel to boot for RHEL >= 8 ansible.builtin.set_fact: grub_set_default_boot_kernel: grub2-set-default - when: ansible_facts['os_family']|lower == 'redhat' and ansible_facts['distribution_major_version'] | int >= 8 + when: ansible_facts['os_family'] | lower == 'redhat' and ansible_facts['distribution_major_version'] | int >= 8 - name: Set the target kernel to be booted by default moving forward if the above command worked become: true diff --git a/playbooks/roles/bootlinux/tasks/update-grub/main.yml b/playbooks/roles/bootlinux/tasks/update-grub/main.yml index d0455b00..db17e7ca 100644 --- a/playbooks/roles/bootlinux/tasks/update-grub/main.yml +++ b/playbooks/roles/bootlinux/tasks/update-grub/main.yml @@ -2,8 +2,8 @@ # tasks to install update-grub - name: Distro specific update of your GRUB boot file ansible.builtin.import_tasks: debian.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/btrfs_progs/tasks/install-deps/main.yml b/playbooks/roles/btrfs_progs/tasks/install-deps/main.yml index 2bd19d15..ca3ff5df 100644 --- a/playbooks/roles/btrfs_progs/tasks/install-deps/main.yml +++ b/playbooks/roles/btrfs_progs/tasks/install-deps/main.yml @@ -1,8 +1,8 @@ --- - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/btrfs_progs/tasks/main.yml b/playbooks/roles/btrfs_progs/tasks/main.yml index 59018370..638c67bf 100644 --- a/playbooks/roles/btrfs_progs/tasks/main.yml +++ b/playbooks/roles/btrfs_progs/tasks/main.yml @@ -34,13 +34,13 @@ - name: Set bindir for debian systems ansible.builtin.set_fact: bindir: "/usr/bin" - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' tags: vars - name: Set bindir for non-debian systems ansible.builtin.set_fact: bindir: "/usr/sbin" - when: ansible_facts['os_family']|lower != 'debian' + when: ansible_facts['os_family'] | lower != 'debian' tags: vars - name: Git clone btrfs_progs diff --git a/playbooks/roles/build_qemu/tasks/install-deps/main.yml b/playbooks/roles/build_qemu/tasks/install-deps/main.yml index 23cda58e..9e108cfd 100644 --- a/playbooks/roles/build_qemu/tasks/install-deps/main.yml +++ b/playbooks/roles/build_qemu/tasks/install-deps/main.yml @@ -10,12 +10,12 @@ - name: Distribution specific setup ansible.builtin.import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat/main.yml when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" - ansible.builtin.import_tasks: fedora/main.yml - when: ansible_facts['distribution']|lower == "fedora" + when: ansible_facts['distribution'] | lower == "fedora" diff --git a/playbooks/roles/compile_dbench/tasks/install-deps/main.yml b/playbooks/roles/compile_dbench/tasks/install-deps/main.yml index 6a06c26f..3f1c3d27 100644 --- a/playbooks/roles/compile_dbench/tasks/install-deps/main.yml +++ b/playbooks/roles/compile_dbench/tasks/install-deps/main.yml @@ -5,6 +5,6 @@ # tasks to install dependencies for dbench - name: Dbench distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' # Other distros can be added on a need basis here diff --git a/playbooks/roles/create_partition/tasks/install-deps/main.yml b/playbooks/roles/create_partition/tasks/install-deps/main.yml index 53f73d20..24765a5a 100644 --- a/playbooks/roles/create_partition/tasks/install-deps/main.yml +++ b/playbooks/roles/create_partition/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install base dependencies to create a partition - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/cxl/tasks/install-deps/main.yml b/playbooks/roles/cxl/tasks/install-deps/main.yml index 5c39717d..adf8ef33 100644 --- a/playbooks/roles/cxl/tasks/install-deps/main.yml +++ b/playbooks/roles/cxl/tasks/install-deps/main.yml @@ -2,11 +2,11 @@ # tasks to install dependencies for oscheck - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' - name: Install package common to all distros ansible.builtin.import_tasks: tasks/install-deps/generic.yml diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index fbe9165e..dfc65dc2 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -658,7 +658,7 @@ ansible.builtin.set_fact: node_host_ip: "{{ ansible_ssh_host }} {{ ansible_default_ipv4.address }}" delegate_facts: true - when: devconfig_enable_systemd_journal_remote|bool + when: devconfig_enable_systemd_journal_remote | bool - name: Set up symlinks for journals tags: ["journal_ln"] @@ -667,7 +667,7 @@ become_flags: "su - -c" become_method: sudo ansible.builtin.command: "{{ topdir_path }}/workflows/kdevops/scripts/jounal-ln.sh {{ devconfig_systemd_journal_remote_path }} {{ node_host_ip }}" - when: devconfig_enable_systemd_journal_remote|bool + when: devconfig_enable_systemd_journal_remote | bool - name: Enables systemd's watchdog ansible.builtin.stat: diff --git a/playbooks/roles/fstests/tasks/install-deps/debian/main.yml b/playbooks/roles/fstests/tasks/install-deps/debian/main.yml index cbcb3788..68bf2adc 100644 --- a/playbooks/roles/fstests/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/fstests/tasks/install-deps/debian/main.yml @@ -93,4 +93,4 @@ - libpcre2-dev - pkg-config - libblkid-dev - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" diff --git a/playbooks/roles/fstests/tasks/install-deps/main.yml b/playbooks/roles/fstests/tasks/install-deps/main.yml index 3d9233fd..e2cfb714 100644 --- a/playbooks/roles/fstests/tasks/install-deps/main.yml +++ b/playbooks/roles/fstests/tasks/install-deps/main.yml @@ -16,8 +16,8 @@ # tasks to install dependencies for oscheck - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/fstests/tasks/install-deps/redhat/main.yml b/playbooks/roles/fstests/tasks/install-deps/redhat/main.yml index c1bd7f82..a935f23e 100644 --- a/playbooks/roles/fstests/tasks/install-deps/redhat/main.yml +++ b/playbooks/roles/fstests/tasks/install-deps/redhat/main.yml @@ -128,4 +128,4 @@ - libsepol-devel - pcre2-devel - gcc-c++ - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml index 3a57a73b..defa4c3a 100644 --- a/playbooks/roles/fstests/tasks/main.yml +++ b/playbooks/roles/fstests/tasks/main.yml @@ -25,7 +25,7 @@ path: "{{ fstests_xfs_xfsprogs_data }}" register: xfsprogs_dir tags: ["oscheck", "git", "fstests"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Set up an iSCSI initiator on target nodes ansible.builtin.include_role: @@ -80,21 +80,21 @@ register: result until: not result.failed tags: ["oscheck", "git", "fstests"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Configure xfsprogs community.general.make: chdir: "{{ fstests_xfs_xfsprogs_data }}" target: configure tags: ["oscheck", "fstests", "build"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Build xfsprogs community.general.make: chdir: "{{ fstests_xfs_xfsprogs_data }}" jobs: "{{ nproc.stdout }}" tags: ["oscheck", "fstests", "build"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Install xfsprogs become: true @@ -106,7 +106,7 @@ DIST_ROOT: "{{ fstests_xfs_xfsprogs_install_path }}" chdir: "{{ fstests_xfs_xfsprogs_data }}" tags: ["oscheck", "fstests", "build"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Check if there's an existing xfsdump directory become: true @@ -179,7 +179,7 @@ line: "export PATH={{ fstests_xfs_xfsprogs_install_path }}/usr/sbin/:$PATH" state: present tags: ["oscheck", "fstests", "build"] - when: "fstests_xfs_build_custom_xfsprogs|bool" + when: "fstests_xfs_build_custom_xfsprogs | bool" - name: Create {{ truncated_path }} if needed ansible.builtin.include_role: diff --git a/playbooks/roles/fstests_prep_localhost/tasks/install-deps/main.yml b/playbooks/roles/fstests_prep_localhost/tasks/install-deps/main.yml index 2c86a030..31b2e3c3 100644 --- a/playbooks/roles/fstests_prep_localhost/tasks/install-deps/main.yml +++ b/playbooks/roles/fstests_prep_localhost/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies for oscheck - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index 44a418b2..a0e8f3e7 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -25,7 +25,7 @@ path: "{{ guestfs_path }}" state: directory mode: "0755" - when: kdevops_enable_guestfs|bool + when: kdevops_enable_guestfs | bool - name: Create nixos directory ansible.builtin.file: @@ -930,7 +930,7 @@ state: directory mode: "0755" with_items: "{{ guestfs_nodes }}" - when: kdevops_enable_guestfs|bool + when: kdevops_enable_guestfs | bool - name: Generate XML files for the libvirt guests for PCI passthrough for guestfs delegate_to: localhost diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml index 872b8eaf..9077927c 100644 --- a/playbooks/roles/gitr/tasks/main.yml +++ b/playbooks/roles/gitr/tasks/main.yml @@ -300,14 +300,14 @@ - name: Save test summary output to a file tags: copy_results ansible.builtin.copy: - content: "{{ gitr_results.stdout_lines|join('\n') }}\n" + content: "{{ gitr_results.stdout_lines | join('\n') }}\n" dest: "{{ gitr_mnt }}/{{ gitr_run_uniqifier }}.summary" mode: "u=rw,g=r,o=r" - name: Save standard error to a file tags: copy_results ansible.builtin.copy: - content: "{{ gitr_results.stderr_lines|join('\n') }}\n" + content: "{{ gitr_results.stderr_lines | join('\n') }}\n" dest: "{{ gitr_mnt }}/{{ gitr_run_uniqifier }}.stderr" mode: "u=rw,g=r,o=r" when: gitr_results.rc != 0 @@ -315,7 +315,7 @@ - name: Save RPC statistics to a file tags: copy_results ansible.builtin.copy: - content: "{{ rpc_results.stdout_lines|join('\n') }}\n" + content: "{{ rpc_results.stdout_lines | join('\n') }}\n" dest: "{{ gitr_mnt }}/{{ gitr_run_uniqifier }}.rpc" mode: "u=rw,g=r,o=r" when: @@ -325,7 +325,7 @@ - name: Save RPC transport statistics to a file tags: copy_results ansible.builtin.copy: - content: "{{ xprt_results.stdout_lines|join('\n') }}\n" + content: "{{ xprt_results.stdout_lines | join('\n') }}\n" dest: "{{ gitr_mnt }}/{{ gitr_run_uniqifier }}.xprt" mode: "u=rw,g=r,o=r" when: diff --git a/playbooks/roles/install-menuconfig-deps/tasks/install-deps/main.yml b/playbooks/roles/install-menuconfig-deps/tasks/install-deps/main.yml index 23cda58e..9e108cfd 100644 --- a/playbooks/roles/install-menuconfig-deps/tasks/install-deps/main.yml +++ b/playbooks/roles/install-menuconfig-deps/tasks/install-deps/main.yml @@ -10,12 +10,12 @@ - name: Distribution specific setup ansible.builtin.import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat/main.yml when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" - ansible.builtin.import_tasks: fedora/main.yml - when: ansible_facts['distribution']|lower == "fedora" + when: ansible_facts['distribution'] | lower == "fedora" diff --git a/playbooks/roles/install_systemd_journal_remote/tasks/install-deps/main.yml b/playbooks/roles/install_systemd_journal_remote/tasks/install-deps/main.yml index 88f3102b..90405c30 100644 --- a/playbooks/roles/install_systemd_journal_remote/tasks/install-deps/main.yml +++ b/playbooks/roles/install_systemd_journal_remote/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/install_systemd_timesyncd/tasks/install-deps/main.yml b/playbooks/roles/install_systemd_timesyncd/tasks/install-deps/main.yml index 88f3102b..90405c30 100644 --- a/playbooks/roles/install_systemd_timesyncd/tasks/install-deps/main.yml +++ b/playbooks/roles/install_systemd_timesyncd/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/install_terraform/tasks/install-deps/main.yml b/playbooks/roles/install_terraform/tasks/install-deps/main.yml index 037e035b..394e5a43 100644 --- a/playbooks/roles/install_terraform/tasks/install-deps/main.yml +++ b/playbooks/roles/install_terraform/tasks/install-deps/main.yml @@ -1,8 +1,8 @@ --- - name: Distribution specific setup ansible.builtin.import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/ktls/tasks/install-deps/main.yml b/playbooks/roles/ktls/tasks/install-deps/main.yml index 7cec015b..d53d7e00 100644 --- a/playbooks/roles/ktls/tasks/install-deps/main.yml +++ b/playbooks/roles/ktls/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies for pynfs - name: Oscheck distribution ospecific setup ansible.builtin.include_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.include_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.include_tasks: redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml index 416f06f3..8ea7dbd1 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/debian/main.yml @@ -14,7 +14,7 @@ ansible.builtin.stat: path: /usr/sbin/apparmor_status register: apparmor_file_stat_result - when: "only_verify_user|bool" + when: "only_verify_user | bool" - name: Verify if AppArmor is disabled when applicable become: true diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml index 3d7ee927..7af90a4e 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml @@ -14,7 +14,7 @@ ansible.builtin.stat: path: /usr/sbin/apparmor_status register: apparmor_file_stat_result - when: "only_verify_user|bool" + when: "only_verify_user | bool" - name: Verify if apparmor is disabled when applicable become: true diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/suse/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/suse/main.yml index 7972956d..168db98e 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/suse/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/suse/main.yml @@ -14,7 +14,7 @@ ansible.builtin.stat: path: /usr/sbin/apparmor_status register: apparmor_file_stat_result - when: "only_verify_user|bool" + when: "only_verify_user | bool" - name: Verify if apparmor is disabled when applicable become: true diff --git a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml index 23cda58e..9e108cfd 100644 --- a/playbooks/roles/libvirt_user/tasks/install-deps/main.yml +++ b/playbooks/roles/libvirt_user/tasks/install-deps/main.yml @@ -10,12 +10,12 @@ - name: Distribution specific setup ansible.builtin.import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: redhat/main.yml when: - ansible_facts['os_family']|lower == 'redhat' - ansible_facts['distribution']|lower != "fedora" - ansible.builtin.import_tasks: fedora/main.yml - when: ansible_facts['distribution']|lower == "fedora" + when: ansible_facts['distribution'] | lower == "fedora" diff --git a/playbooks/roles/minio_warp_run/tasks/main.yml b/playbooks/roles/minio_warp_run/tasks/main.yml index 6c5abe72..490bae5b 100644 --- a/playbooks/roles/minio_warp_run/tasks/main.yml +++ b/playbooks/roles/minio_warp_run/tasks/main.yml @@ -160,7 +160,7 @@ --duration="{{ minio_warp_duration }}" \ --concurrent="{{ minio_warp_concurrent_requests }}" \ --obj.size="{{ minio_warp_object_size }}" \ - {% if minio_warp_enable_web_ui|default(false) %}--warp-client="{{ ansible_default_ipv4.address }}:{{ minio_warp_web_ui_port|default(7762) }}"{% endif %} \ + {% if minio_warp_enable_web_ui|default(false) %}--warp-client="{{ ansible_default_ipv4.address }}:{{ minio_warp_web_ui_port | default(7762) }}"{% endif %} \ --noclear \ --json > "$OUTPUT_FILE" 2>&1 RESULT=$? diff --git a/playbooks/roles/mmtests/tasks/install-deps/main.yml b/playbooks/roles/mmtests/tasks/install-deps/main.yml index 84108053..5fa8c659 100644 --- a/playbooks/roles/mmtests/tasks/install-deps/main.yml +++ b/playbooks/roles/mmtests/tasks/install-deps/main.yml @@ -5,12 +5,12 @@ # Distribution-specific setup for mmtests dependencies - name: Debian/Ubuntu distribution specific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - name: SUSE distribution specific setup ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - name: RedHat distribution specific setup ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/mmtests_compare/tasks/main.yml b/playbooks/roles/mmtests_compare/tasks/main.yml index 14bc6cc1..6a25ec22 100644 --- a/playbooks/roles/mmtests_compare/tasks/main.yml +++ b/playbooks/roles/mmtests_compare/tasks/main.yml @@ -17,7 +17,7 @@ - python3-numpy state: present update_cache: true - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' run_once: true tags: ["compare", "deps"] @@ -29,7 +29,7 @@ name: "{{ item }}" with_items: - File::Temp - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' run_once: true tags: ["compare", "deps"] ignore_errors: true @@ -54,7 +54,7 @@ - python3-matplotlib - python3-numpy state: present - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' run_once: true tags: ["compare", "deps"] @@ -78,7 +78,7 @@ - python3-matplotlib - python3-numpy state: present - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' run_once: true tags: ["compare", "deps"] @@ -175,7 +175,7 @@ - "{{ baseline_hostname }}-{{ baseline_kernel }}" - "{{ dev_hostname }}-{{ dev_kernel }}" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Archive baseline results on remote @@ -194,7 +194,7 @@ format: gz delegate_to: "{{ groups['dev'][0] }}" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Fetch baseline results to localhost @@ -213,7 +213,7 @@ flat: true delegate_to: "{{ groups['dev'][0] }}" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Extract baseline results locally @@ -232,7 +232,7 @@ dest: "{{ topdir_path }}/tmp/mmtests/work/log/" remote_src: true run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Run mmtests comparison @@ -245,7 +245,7 @@ --names {{ baseline_hostname }}-{{ baseline_kernel }},{{ dev_hostname }}-{{ dev_kernel }} chdir: "{{ topdir_path }}/tmp/mmtests" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool register: comparison_text_output tags: ["compare"] @@ -260,7 +260,7 @@ --format html chdir: "{{ topdir_path }}/tmp/mmtests" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool register: comparison_html_output tags: ["compare"] @@ -269,13 +269,13 @@ ansible.builtin.set_fact: comparison_metrics: [] run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Generate performance graphs using gnuplot delegate_to: localhost run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare", "graphs"] block: - name: Check for available iterations data @@ -406,7 +406,7 @@ monitor_graphs: [] summary_stats: [] run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Save comparison outputs @@ -421,7 +421,7 @@ - content: "{{ comparison_html_output.stdout | default('<p>No comparison data</p>') }}" dest: "{{ topdir_path }}/workflows/mmtests/results/compare/comparison_raw.html" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Copy full results to final location @@ -434,7 +434,7 @@ - "{{ baseline_hostname }}-{{ baseline_kernel }}" - "{{ dev_hostname }}-{{ dev_kernel }}" run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Display comparison report location @@ -456,7 +456,7 @@ 🚀 Open comparison_report.html for the best analysis experience! run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare"] - name: Clean up temporary archives on remote nodes @@ -468,5 +468,5 @@ - baseline - dev run_once: true - when: kdevops_baseline_and_dev|bool + when: kdevops_baseline_and_dev | bool tags: ["compare", "cleanup"] diff --git a/playbooks/roles/monitoring/tasks/monitor_run.yml b/playbooks/roles/monitoring/tasks/monitor_run.yml index f56d06e4..9e6308d3 100644 --- a/playbooks/roles/monitoring/tasks/monitor_run.yml +++ b/playbooks/roles/monitoring/tasks/monitor_run.yml @@ -31,7 +31,7 @@ echo "$(date +"%Y-%m-%d %H:%M:%S")" >> /root/monitoring/folio_migration_stats.txt cat /sys/kernel/debug/mm/migrate/stats >> /root/monitoring/folio_migration_stats.txt echo "" >> /root/monitoring/folio_migration_stats.txt - sleep {{ monitor_folio_migration_interval|default(60) }} + sleep {{ monitor_folio_migration_interval | default(60) }} done' > /root/monitoring/folio_migration.log 2>&1 & echo $! > /root/monitoring/folio_migration.pid async: 86400 # Run for up to 24 hours diff --git a/playbooks/roles/nfsd/tasks/install-deps/debian/main.yml b/playbooks/roles/nfsd/tasks/install-deps/debian/main.yml index 1ad9cc53..f76047df 100644 --- a/playbooks/roles/nfsd/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/nfsd/tasks/install-deps/debian/main.yml @@ -24,7 +24,7 @@ - name: Add gssproxy to the nfsd packages list ansible.builtin.set_fact: nfsd_packages: "{{ nfsd_packages + ['gssproxy'] }}" - when: kdevops_krb5_enable|bool + when: kdevops_krb5_enable | bool - name: Install nfsd dependencies become: true diff --git a/playbooks/roles/nfsd/tasks/install-deps/suse/main.yml b/playbooks/roles/nfsd/tasks/install-deps/suse/main.yml index be7fbd50..18a795d6 100644 --- a/playbooks/roles/nfsd/tasks/install-deps/suse/main.yml +++ b/playbooks/roles/nfsd/tasks/install-deps/suse/main.yml @@ -24,7 +24,7 @@ - name: Add additional packages needed for krb5 to the nfsd packages list ansible.builtin.set_fact: nfsd_packages: "{{ nfsd_packages + ['gssproxy', 'libverto-libev1'] }}" - when: kdevops_krb5_enable|bool + when: kdevops_krb5_enable | bool - name: Install nfsd dependencies become: true diff --git a/playbooks/roles/pkg/tasks/main.yml b/playbooks/roles/pkg/tasks/main.yml index d7e34483..b6af2683 100644 --- a/playbooks/roles/pkg/tasks/main.yml +++ b/playbooks/roles/pkg/tasks/main.yml @@ -1,4 +1,4 @@ --- - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/debian.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' diff --git a/playbooks/roles/pynfs/tasks/install-deps/main.yml b/playbooks/roles/pynfs/tasks/install-deps/main.yml index 806916e0..77f52223 100644 --- a/playbooks/roles/pynfs/tasks/install-deps/main.yml +++ b/playbooks/roles/pynfs/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies for pynfs - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/reboot-limit/tasks/install-deps/main.yml b/playbooks/roles/reboot-limit/tasks/install-deps/main.yml index d8e0539f..6d035997 100644 --- a/playbooks/roles/reboot-limit/tasks/install-deps/main.yml +++ b/playbooks/roles/reboot-limit/tasks/install-deps/main.yml @@ -5,8 +5,8 @@ # tasks to install dependencies for reboot-limit - name: Reboot-limit distribution specific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/reboot-limit/tasks/main.yml b/playbooks/roles/reboot-limit/tasks/main.yml index 1c34c80a..48120c02 100644 --- a/playbooks/roles/reboot-limit/tasks/main.yml +++ b/playbooks/roles/reboot-limit/tasks/main.yml @@ -24,7 +24,7 @@ ansible.builtin.file: path: "{{ reboot_limit_data }}/{{ ansible_ssh_host }}" state: directory - when: not reboot_limit_compare_both_enabled|default(false)|bool + when: not reboot_limit_compare_both_enabled | default(false) | bool tags: ["install", "first_run"] - name: Create the regular reboot data collection directory for comparison mode @@ -33,7 +33,7 @@ ansible.builtin.file: path: "{{ reboot_limit_data_regular }}/{{ ansible_ssh_host }}" state: directory - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool tags: ["install", "first_run"] - name: Create the kexec reboot data collection directory for comparison mode @@ -42,7 +42,7 @@ ansible.builtin.file: path: "{{ reboot_limit_data_kexec }}/{{ ansible_ssh_host }}" state: directory - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool tags: ["install", "first_run"] - name: Set the file to collect systemctl-analyze results @@ -70,7 +70,7 @@ - "{{ reboot_limit_count_file }}" loop_control: label: "{{ item | regex_replace(reboot_limit_data | regex_escape()) | regex_replace('^/', '') }}" - when: not reboot_limit_compare_both_enabled|default(false)|bool + when: not reboot_limit_compare_both_enabled | default(false) | bool tags: ["reset"] - name: Delete old results directory files if a reset was called (comparison mode - regular) @@ -79,7 +79,7 @@ ansible.builtin.file: path: "{{ reboot_limit_data_regular }}/{{ ansible_ssh_host }}" state: absent - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool tags: ["reset"] - name: Delete old results directory files if a reset was called (comparison mode - kexec) @@ -88,7 +88,7 @@ ansible.builtin.file: path: "{{ reboot_limit_data_kexec }}/{{ ansible_ssh_host }}" state: absent - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool tags: ["reset"] - name: Set the path where we collect our local reboot-limit results @@ -117,7 +117,7 @@ with_sequence: count={{ reboot_limit_max }} loop_control: loop_var: reboot_num - when: not reboot_limit_compare_both_enabled|default(false)|bool + when: not reboot_limit_compare_both_enabled | default(false) | bool tags: ["run_tests"] - name: Run the reboot comparison loop (both regular and kexec) @@ -125,7 +125,7 @@ with_sequence: count={{ reboot_limit_max }} loop_control: loop_var: reboot_num - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool tags: ["run_tests"] - name: Copy the latest results over when we're done (single mode) @@ -142,7 +142,7 @@ - "{{ reboot_limit_count_file }}" loop_control: label: "{{ item | regex_replace(reboot_limit_data | regex_escape()) | regex_replace('^/', '') }}" - when: not reboot_limit_compare_both_enabled|default(false)|bool + when: not reboot_limit_compare_both_enabled | default(false) | bool - name: Copy the regular reboot results in comparison mode tags: ["copy_results"] @@ -156,7 +156,7 @@ with_items: - "{{ reboot_limits_systemctl_analyze_log }}" - "{{ reboot_limits_count_log }}" - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool - name: Copy the kexec reboot results in comparison mode tags: ["copy_results"] @@ -170,4 +170,4 @@ with_items: - "{{ reboot_limits_systemctl_analyze_log }}" - "{{ reboot_limits_count_log }}" - when: reboot_limit_compare_both_enabled|default(false)|bool + when: reboot_limit_compare_both_enabled | default(false) | bool diff --git a/playbooks/roles/selftests/tasks/install-deps/main.yml b/playbooks/roles/selftests/tasks/install-deps/main.yml index b96f76cf..d5b046d3 100644 --- a/playbooks/roles/selftests/tasks/install-deps/main.yml +++ b/playbooks/roles/selftests/tasks/install-deps/main.yml @@ -2,8 +2,8 @@ # tasks to install dependencies for selftests - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/selftests/tasks/main.yml b/playbooks/roles/selftests/tasks/main.yml index f8af3080..a1868566 100644 --- a/playbooks/roles/selftests/tasks/main.yml +++ b/playbooks/roles/selftests/tasks/main.yml @@ -448,7 +448,7 @@ become_flags: "su - -c" become_method: sudo ansible.builtin.copy: - content: "{{ selftests_out.stdout_lines|join('\n') }}" + content: "{{ selftests_out.stdout_lines | join('\n') }}" dest: "{{ selftests_workdir }}/tap.log" when: - kdevops_run_selftests|bool @@ -460,7 +460,7 @@ become_flags: "su - -c" become_method: sudo ansible.builtin.copy: - content: "{{ selftests_userspace_out.stdout_lines|join('\n') }}" + content: "{{ selftests_userspace_out.stdout_lines | join('\n') }}" dest: "{{ selftests_workdir }}/userspace.log" when: - selftest_userspace|bool @@ -471,7 +471,7 @@ become_flags: "su - -c" become_method: sudo ansible.builtin.copy: - content: "{{ selftests_module_out.stdout_lines|join('\n') }}" + content: "{{ selftests_module_out.stdout_lines | join('\n') }}" dest: "{{ selftests_workdir }}/module.log" when: - selftest_userspace|bool diff --git a/playbooks/roles/steady_state/tasks/main.yaml b/playbooks/roles/steady_state/tasks/main.yaml index bab189e3..d22409e7 100644 --- a/playbooks/roles/steady_state/tasks/main.yaml +++ b/playbooks/roles/steady_state/tasks/main.yaml @@ -113,7 +113,7 @@ ansible.builtin.command: /usr/sbin/blockdev --getsize64 {{ ssd_steady_state_device }} register: device_capacity_raw changed_when: false - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Set block device properties as facts @@ -151,7 +151,7 @@ {{ device_physical_block_size | trim | int }} {% endif %} effective_jobs: "{{ ssd_steady_state_numjobs | default(ansible_processor_vcpus, true) | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Fix syntax for effective_blocksize @@ -190,7 +190,7 @@ ansible.builtin.set_fact: aligned_pbs_blocks: "{{ (effective_max_size | int) // (effective_physical_bs | int) }}" aligned_bs_per_block: "{{ (effective_blocksize | int) // (effective_physical_bs | int) }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Calculate aligned blocks and job distribution @@ -198,7 +198,7 @@ become_method: sudo ansible.builtin.set_fact: aligned_blocks: "{{ aligned_pbs_blocks | int // aligned_bs_per_block | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Calculate job alignment @@ -206,7 +206,7 @@ become_method: sudo ansible.builtin.set_fact: blocks_per_job_remainder: "{{ aligned_blocks | int % effective_jobs | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Set aligned job distribution @@ -215,7 +215,7 @@ ansible.builtin.set_fact: aligned_jobs: "{{ effective_jobs if blocks_per_job_remainder == 0 else (effective_jobs | int - 1) }}" unaligned_jobs: "{{ 0 if blocks_per_job_remainder == 0 else 1 }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Set aligned blocks per job @@ -223,7 +223,7 @@ become_method: sudo ansible.builtin.set_fact: aligned_blocks_per_job: "{{ aligned_blocks | int // aligned_jobs | int if blocks_per_job_remainder != 0 else aligned_blocks | int // effective_jobs | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Calculate byte distribution for jobs @@ -232,7 +232,7 @@ ansible.builtin.set_fact: aligned_block_bytes: "{{ aligned_blocks_per_job | int * effective_blocksize | int }}" total_aligned_block_bytes: "{{ aligned_blocks_per_job | int * effective_blocksize | int * aligned_jobs | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Calculate remainder bytes for unaligned job @@ -240,7 +240,7 @@ become_method: sudo ansible.builtin.set_fact: remainder_block_bytes: "{{ effective_max_size | int - total_aligned_block_bytes | int }}" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["prefill"] - name: Validate job byte alignment to blocksize @@ -324,7 +324,7 @@ --warnings-fatal --output-format=json+ --output={{ steady_state_data }}/ss_iops.json - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["steady_state"] - name: Run fio steady state for bw @@ -336,7 +336,7 @@ --warnings-fatal --output-format=json+ --output={{ steady_state_data }}/ss_bw.json - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["steady_state"] - name: Create local results directory @@ -357,5 +357,5 @@ recursive: true rsync_opts: - "--ignore-existing" - when: kdevops_run_ssd_steady_state|bool + when: kdevops_run_ssd_steady_state | bool tags: ["results"] diff --git a/playbooks/roles/sysbench/tasks/install-deps/debian/main.yml b/playbooks/roles/sysbench/tasks/install-deps/debian/main.yml index bd091389..f188e0e0 100644 --- a/playbooks/roles/sysbench/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/sysbench/tasks/install-deps/debian/main.yml @@ -28,7 +28,7 @@ state: present update_cache: true tags: ["deps"] - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Install PosgreSQL build deps tags: ["deps"] @@ -47,7 +47,7 @@ - zlib1g-dev state: present update_cache: true - when: "sysbench_type_postgresql_native|bool" + when: "sysbench_type_postgresql_native | bool" # acl - Required for running Ansible with unpriviledge user (sysbench_postgresql_user) # https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_privilege_escalation.html#risks-of-becoming-an-unprivileged-user @@ -62,7 +62,7 @@ - nvme-cli state: present update_cache: true - when: "sysbench_type_postgresql_native|bool" + when: "sysbench_type_postgresql_native | bool" - name: Install sysbench deps tags: ["deps"] @@ -74,7 +74,7 @@ - rsync state: present update_cache: true - when: "sysbench_type_postgresql_native|bool" + when: "sysbench_type_postgresql_native | bool" - name: Install plot deps tags: ["deps"] @@ -87,4 +87,4 @@ - python3-seaborn state: present update_cache: true - when: "sysbench_type_postgresql_native|bool" + when: "sysbench_type_postgresql_native | bool" diff --git a/playbooks/roles/sysbench/tasks/install-deps/main.yml b/playbooks/roles/sysbench/tasks/install-deps/main.yml index bdc3de4c..786d0144 100644 --- a/playbooks/roles/sysbench/tasks/install-deps/main.yml +++ b/playbooks/roles/sysbench/tasks/install-deps/main.yml @@ -5,8 +5,8 @@ # tasks to install dependencies for oscheck - name: Oscheck distribution ospecific setup ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' + when: ansible_facts['os_family'] | lower == 'debian' - ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' + when: ansible_facts['os_family'] | lower == 'suse' - ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' + when: ansible_facts['os_family'] | lower == 'redhat' diff --git a/playbooks/roles/sysbench/tasks/mysql-docker/main.yaml b/playbooks/roles/sysbench/tasks/mysql-docker/main.yaml index ae53b587..4f524f39 100644 --- a/playbooks/roles/sysbench/tasks/mysql-docker/main.yaml +++ b/playbooks/roles/sysbench/tasks/mysql-docker/main.yaml @@ -7,7 +7,7 @@ path: "{{ sysbench_telemetry_path }}" state: directory mode: "u=rwx,g=rx,o=rx" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" tags: ["setup"] - name: Ensure MySQL root user directory exists @@ -18,7 +18,7 @@ path: "{{ sysbench_mysql_container_host_root_path }}" state: directory mode: "u=rwx,g=rx,o=rx" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" tags: ["setup"] - name: Determine filesystem setting used and db page size @@ -93,7 +93,7 @@ name: "{{ sysbench_container_name }}" image: "{{ sysbench_container_image_name }}" state: absent - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Remove any old MySQL container tags: ["post_entrypoint", "clean"] @@ -104,7 +104,7 @@ name: "{{ sysbench_mysql_container_name }}" image: "{{ sysbench_mysql_container_image_string }}" state: absent - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Unmount {{ sysbench_mnt }} become: true @@ -156,7 +156,7 @@ src: "{{ sysbench_mysql_container_host_client_config_path | basename }}.j2" dest: "{{ sysbench_mysql_container_host_client_config_path }}" mode: "u=rw,g=r,o=r" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Generate MySQL server configuration file from template tags: ["setup"] @@ -164,7 +164,7 @@ src: "{{ sysbench_mysql_container_host_config_path | basename }}.j2" dest: "{{ sysbench_mysql_container_host_config_path }}" mode: "u=rw,g=r,o=r" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Create a few directories needed for telemetry inside the docker container tags: ["setup"] @@ -189,7 +189,7 @@ dest: "{{ sysbench_mysql_container_host_root_path }}/.mysqlsh/plugins/" update: true version: master - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Get used target kernel version tags: ["db_start"] @@ -255,7 +255,7 @@ MYSQL_DATABASE: "{{ sysbench_db_name }}" MYSQL_ROOT_PASSWORD: "{{ sysbench_root_db_password }}" PYTHONPATH: "{{ sysbench_mysql_container_python_path }}" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Wait for for it... (MySQL data port to be up) tags: ["db_start"] @@ -275,7 +275,7 @@ retries: 12 # Retry up to 12 times delay: 5 # Delay 5 seconds between retries until: result.rc == 0 - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Verify MySQL client works inside Docker container using explicit socket tags: ["db_start"] @@ -286,7 +286,7 @@ command: mysql --socket=/var/lib/mysql/mysql.sock -e "SHOW DATABASES;" register: mysql_socket_output_explicit ignore_errors: true - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL client explicit socket test output to a file on the host tags: ["db_start"] @@ -295,7 +295,7 @@ ansible.builtin.copy: content: "{{ mysql_socket_output_explicit.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-mysql-client-explicit-test.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Verify MySQL client works on server and capture output tags: ["db_start"] @@ -305,7 +305,7 @@ container: "{{ sysbench_mysql_container_name }}" command: mysql -h localhost -e "SHOW DATABASES;" register: mysql_socket_output - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL client socket test output to a file on the host tags: ["db_start"] @@ -314,7 +314,7 @@ ansible.builtin.copy: content: "{{ mysql_socket_output.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-mysql-client-test.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Add sysbench test user using the MySQL container tags: ["post_entrypoint"] @@ -325,7 +325,7 @@ container: "{{ sysbench_mysql_container_name }}" command: mysql -e "CREATE USER {{ sysbench_db_username }}@'%' IDENTIFIED WITH 'mysql_native_password' BY '{{ sysbench_db_password }}';" register: mysql_add_sysbench_user - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL output of adding sysbench user tags: ["post_entrypoint"] @@ -334,7 +334,7 @@ ansible.builtin.copy: content: "{{ mysql_add_sysbench_user.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-0001-add-user.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Grant sysbench test user privileges using the MySQL container tags: ["post_entrypoint"] @@ -345,7 +345,7 @@ container: "{{ sysbench_mysql_container_name }}" command: mysql -e "GRANT ALL PRIVILEGES ON {{ sysbench_db_name }}.* to {{ sysbench_db_username }}@'%';" register: mysql_sysbench_privs - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL output of granting all privileges to sysbench user tags: ["post_entrypoint"] @@ -354,7 +354,7 @@ ansible.builtin.copy: content: "{{ mysql_sysbench_privs.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-0002-grant-privs-user.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Flush privileges tags: ["post_entrypoint"] @@ -364,7 +364,7 @@ community.docker.docker_container_exec: container: "{{ sysbench_mysql_container_name }}" command: mysql -e "FLUSH PRIVILEGES;" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Install pip using MySQL container tags: ["post_entrypoint"] @@ -375,7 +375,7 @@ container: "{{ sysbench_mysql_container_name }}" command: microdnf install -y python-pip register: mysql_pip - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL output of installing pip tags: ["post_entrypoint"] @@ -384,7 +384,7 @@ ansible.builtin.copy: content: "{{ mysql_pip.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-0003-install-python-pip.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Install Python packages we need for telemetry pip using the MySQL container tags: ["post_entrypoint"] @@ -397,7 +397,7 @@ env: PYTHONPATH: "{{ sysbench_mysql_container_python_path }}" register: mysql_pip_install_deps - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save MySQL output of installing telemetry reqs with pip tags: ["post_entrypoint"] @@ -406,7 +406,7 @@ ansible.builtin.copy: content: "{{ mysql_pip_install_deps.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/root-setup-0004-install-telemetry-reqs.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Ensure sysbench user is present on the mysql container tags: ["post_entrypoint"] @@ -418,7 +418,7 @@ command: mysql -e "SELECT user, host, plugin FROM mysql.user WHERE user = '{{ sysbench_db_username }}' AND plugin = 'mysql_native_password';" register: user_check_result failed_when: user_check_result.stdout.find(sysbench_db_username) == -1 - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Remove the sysbench container tags: ["populate_sbtest"] @@ -429,7 +429,7 @@ name: "{{ sysbench_container_name }}" image: "{{ sysbench_container_image_name }}" state: absent - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Start a sysbench container we will re-use for population and running the test tags: ["populate_sbtest"] @@ -446,7 +446,7 @@ detach: true restart_policy: unless-stopped command: "tail -f /dev/null" # Keeps the container running - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Wait for the sysbench container to be in running state tags: ["populate_sbtest"] @@ -459,7 +459,7 @@ until: sysbench_container_status.container is defined and sysbench_container_status.container.State.Running retries: 5 delay: 5 - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" # Keep this at threads=1 as multiple threads don't work when building the # initial database. @@ -485,7 +485,7 @@ --mysql-password={{ sysbench_db_password }} run register: sysbench_init_pop - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save the output of popuating the initial sysench database tags: ["post_entrypoint"] @@ -494,7 +494,7 @@ ansible.builtin.copy: content: "{{ sysbench_init_pop.stdout }}" dest: "{{ sysbench_docker_telemetry_path }}/sysbench_populate.txt" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" # We use a shell here to be able to directly output to a file instad # of saving to an ansible variable with register because we expect this @@ -526,7 +526,7 @@ async: "{{ sysbench_test_duration | int + 10 }}" # Maximum allowed time to complete poll: 0 # Run in the background register: sysbench_job # Register the job ID - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Collect MySQL telemetry inside the Docker MySQL container at the same time tags: ["telemetry", "tel"] @@ -542,7 +542,7 @@ command: | mysqlsh --execute "support.collect(mysql=true, os=true, time={{ sysbench_test_duration | int // 60 }}, outputdir='{{ sysbench_telemetry_path }}')" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Wait for sysbench workload to complete tags: ["run_sysbench"] @@ -570,7 +570,7 @@ ansible.builtin.command: cmd: "docker logs {{ sysbench_container_name }}" register: sysbench_logs - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save sysbench logs to a file on the local machine become: true @@ -580,7 +580,7 @@ ansible.builtin.copy: content: "{{ sysbench_logs.stdout }}" dest: "{{ sysbench_telemetry_path }}/docker-sysbench-results-{{ ansible_date_time.iso8601 }}.log" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Collect sysbench docker logs for MySQL container tags: ["logs"] @@ -591,7 +591,7 @@ cmd: "docker logs {{ sysbench_mysql_container_name }}" register: sysbench_mysql_container_logs changed_when: false - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Save docker MySQL logs on node tags: ["logs"] @@ -602,7 +602,7 @@ content: "{{ sysbench_mysql_container_logs.stdout }}" dest: "{{ sysbench_telemetry_path }}/docker-mysql-results-{{ ansible_date_time.iso8601 }}.log" mode: "u=rw,g=r,o=r" - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Remove the sysbench container which ran the benchmark tags: ["run_sysbench"] @@ -613,7 +613,7 @@ name: "{{ sysbench_container_name }}" image: "{{ sysbench_container_image_name }}" state: absent - when: "sysbench_type_mysql_docker|bool" + when: "sysbench_type_mysql_docker | bool" - name: Copy telemetry data from each node to the localhost tags: ["results"] -- 2.50.1