[PATCH 1/4] workflows: linux: remove explicit inventory in ansible wrappers
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> The A/B testing implementation introduced back the --inventory argument for the ansible-playbook invocation patterns. Three targets (linux, linux-baseline, linux-dev) were using '-i hosts' instead of leveraging the ansible.cfg inventory key + the established '--limit' or hosts: YAML field. Also, for bootlinux playbook case, this caused the playbook to run on localhost, leading to failures when localhost doesn't have the required virtualization setup: - virtio devices (/dev/disk/by-id/virtio-kdevops0) - 9p kernel modules and filesystem support - target directory structure (/data/linux-stable) - etc. Fixes: 7f25db722 ("bootlinux: add support for A/B kernel testing") Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- workflows/linux/Makefile | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/workflows/linux/Makefile b/workflows/linux/Makefile index 1ab9d55d..23a59968 100644 --- a/workflows/linux/Makefile +++ b/workflows/linux/Makefile @@ -101,8 +101,9 @@ ifeq (y,$(CONFIG_BOOTLINUX_AB_DIFFERENT_REF)) linux: linux-baseline linux-dev else linux: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS) endif else @@ -116,9 +117,10 @@ endif PHONY += linux-baseline ifeq (y,$(CONFIG_KDEVOPS_BASELINE_AND_DEV)) linux-baseline: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ - --extra-vars="$(BOOTLINUX_ARGS)" --limit baseline + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit baseline \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + --extra-vars="$(BOOTLINUX_ARGS)" else linux-baseline: @echo "linux-baseline requires KDEVOPS_BASELINE_AND_DEV=y" @@ -128,9 +130,10 @@ endif PHONY += linux-dev ifeq (y,$(CONFIG_KDEVOPS_BASELINE_AND_DEV)) linux-dev: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ - --extra-vars="$(BOOTLINUX_ARGS)" --limit dev + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit dev \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + --extra-vars="$(BOOTLINUX_ARGS)" else linux-dev: @echo "linux-dev requires KDEVOPS_BASELINE_AND_DEV=y" -- 2.50.1