Re: [PATCH] Makefile: terraform wasn't building the kdevops_nodes file

On 02/10/2025 22.13, Chuck Lever wrote:
> From: Daniel Gomez <[email protected]>
> 
> When "make bringup" runs "terraform plan", it complains that the
> kdevops_nodes variable isn't set.
> 
> extra_vars.yaml does contain the variable, but I'm guessing that
> somehow gen_nodes runs after gen_tfvars now? Not really sure.
> 
> Daniel suggests:
>> I think it'd be best to move KDEVOPS_NODES just after we assign
>> the filename to it (provision.Makefile -> guestfs.Makefile):
> 
> Fixes: 5457b742d611 ("Makefile: fix target dependency order")
> Signed-off-by: Daniel Gomez <[email protected]>
> ---
>  Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Daniel, I've totally lost the plot. Is this patch adequate for fixing
> the "terraform plan" failures, or do you have something else in mind?

Yes, that is correct becuase we want/need to fill DEFAULT_DEPS after
KDEVOPS_NODES is generated.

And sorry if I made it so confusing!