Re: [PATCH v2 0/8] nfs: few fixes and enhancements

On Fri, Oct 03, 2025 at 04:19:48PM -0400, Chuck Lever wrote:
> From: Chuck Lever <[email protected]>
> 
> Original cover:
> 
> In prepration for talking about NFS tests at the MSST conference today
> I figured I'd give a run to all NFS tests. I ran out of time but at
> least this plumbed quite a bit of the stuff to get some results out.
> 
> The iSCSI stuff is likely not correct, and can be dropped. So, feel
> free to take in only what makes sense and drop whatever silly thing
> you see.
> 
> Updates:
> 
> I'm reposting because, strangely, I never received these patches in
> my inbox. I pulled this series from lore using "b4 am" so we can
> keep reviewing.
> 
> For "devconfig: exclude nfsd from journal upload client
> configuration", I wonder if instead of "nfsd", the new checks
> should look for the "service" group, which usually includes nfsd,
> the SMB server, the iscsi target, and the Kerberos KDC. Any opinion
> on that?
> 
> I've dropped the iSCSI-specific changes. Except for a couple of
> nits, the remaining patches look great to me.
> 
> The original idea for pNFS block testing was that a separate iSCSI
> target was to be set up: either it is outside the kdevops test
> network, or it is enabled by setting CONFIG_KDEVOPS_ENABLE_ISCSI.
> Then change the kdevops nfsd server to use that iSCSI target by
> changing the "Persistent storage for exported file systems" setting
> to "iSCSI".
> 
> It's easier overall if the iSCSI target host is separate from the
> kdevops nfsd host. iSCSI loopback is not as performant and is less
> reliable, I've found -- and maybe not supported on every Linux
> distribution we want to run kdevops on, IIRC.
> 
> The gitr, nfstest, and pynfs workflows should all be able to use
> pNFS block, and indeed the latter two have additional tests
> especially for pNFS block layout. So fstests-specific pNFS block
> patches don't seem right to me.
> 
> Luis, if you believe I missed something and need to revisit one or
> more of the patches I've left out, please don't hesitate to bring
> it up.

Luis great, sorry the machines think I'm a spammer somehow! Please push!

  Luis