Re: [PATCH 1/2] devconfig: drop locales-all leftovers

On 29/09/2025 21.04, Daniel Gomez wrote:
> From: Daniel Gomez <[email protected]>
> 
> When locales-all support was added in commit 2514a694 ("guestfs: fix
> locale warnings in VM deployment"), it was added for all distros in the
> virt-builder.j2 template as well as Ansible tasks to ensure idempotency
> on previous base images.
> 
> But we just need to ensure en_US.UTF-8 is available on the guests
> image, so keep just this config in both template and tasks but remove
> locales-all.
> 
> While we are at it, also move the locale configuration after all deps
> are installed and to the distro agnostic task section. We do it anyways
> for all distros in virt-builder.j2, this ensures idempotency in all
> of them.
> 
> Fixes: 6bb3bfb2 ("base_image: Skip "locales-all" package installation")
> Signed-off-by: Daniel Gomez <[email protected]>
> ---
>  playbooks/roles/devconfig/tasks/main.yml | 50 +++++++++++---------------------
>  1 file changed, 17 insertions(+), 33 deletions(-)
> 
> diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml
> index ae16a698..1acca6b4 100644
> --- a/playbooks/roles/devconfig/tasks/main.yml
> +++ b/playbooks/roles/devconfig/tasks/main.yml
...
> @@ -80,8 +88,6 @@
>      - { path: "/etc/default/locale", line: "LANG=en_US.UTF-8" }
>      - { path: "/etc/default/locale", line: "LANGUAGE=en_US:en" }
>      - { path: "/etc/locale.gen", line: "en_US.UTF-8 UTF-8" }
> -  when:
> -    - ansible_facts['os_family']|lower == 'debian'

FYI, I plan to merge this tomorrow as this patchset solves the current
linux-ci issue [1]. Please note that this change affects all distributions.
I believe this is the correct approach and will proceed with it to restore CI
functionality. Please, let me know if you find it breaks something on non-Debian
distros.

Link: https://github.com/linux-kdevops/kdevops/actions/runs/18347971703/job/52259752236 [1]