[PATCH v2 08/15] devconfig: fix Ansible boolean conditional for custom repos

Daniel Gomez <[email protected]> Wed, 29 Oct 2025 13:40:50 +0100
Newsgroups dev.linux.lists.kdevops
Message-ID <[email protected]>
From: Daniel Gomez <[email protected]>

Newer Ansible versions reject string variables in conditionals without
explicit boolean expressions, producing "Conditional result was derived
from type 'str'" errors.

Remove the redundant string variable check. The length test already
evaluates to boolean (length > 1), properly handling empty strings by
skipping the task.

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>
---
 .../devconfig/tasks/config-custom-repos-and-packages/redhat/main.yml    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/playbooks/roles/devconfig/tasks/config-custom-repos-and-packages/redhat/main.yml b/playbooks/roles/devconfig/tasks/config-custom-repos-and-packages/redhat/main.yml
index 0a772dd7..76d1ce3c 100644
--- a/playbooks/roles/devconfig/tasks/config-custom-repos-and-packages/redhat/main.yml
+++ b/playbooks/roles/devconfig/tasks/config-custom-repos-and-packages/redhat/main.yml
@@ -10,7 +10,6 @@
     mode: "0644"
   with_items: "{{ kdevops_devconfig_custom_repos | trim | split(',') }}"
   when:
-    - kdevops_devconfig_custom_repos
     - kdevops_devconfig_custom_repos | trim | length > 1
 
 - name: Install custom packages
@@ -24,5 +23,4 @@
   until: result.rc == 0
   with_items: "{{ kdevops_devconfig_custom_packages | trim | split(',') }}"
   when:
-    - kdevops_devconfig_custom_packages
     - kdevops_devconfig_custom_packages | trim | length > 1

-- 
2.51.0