[PATCH 02/12] linux-mirror: fix missing systemd timers for five git repositories
Daniel Gomez <[email protected]> Thu, 06 Nov 2025 23:35:56 +0100
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> The mirror setup was failing to generate systemd timer and service units for mmtests, modules, stable-rc, vfs, and xfs repositories. This occurred due to configuration bugs where protocol selection options were mapped to incorrect or non-existent URL defaults. The modules and xfs mirror configurations incorrectly mapped the git:// protocol option to HTTPS URL defaults instead of the git:// URL defaults. This caused git clone operations to use the wrong protocol when users selected git:// in menuconfig. The mmtests and stable-rc configurations were missing the output yaml marker entirely, which prevented Ansible from receiving these variables through extra_vars.yaml. Additionally, the mmtests template was using a hardcoded default instead of the configurable variable. With these corrections, all five repositories now generate proper systemd units and respect the user's protocol selection from menuconfig. Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- kconfigs/Kconfig.mirror | 10 ++++++---- playbooks/roles/linux-mirror/templates/mirrors.yaml.j2 | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/kconfigs/Kconfig.mirror b/kconfigs/Kconfig.mirror index a8728f0a..6a66a510 100644 --- a/kconfigs/Kconfig.mirror +++ b/kconfigs/Kconfig.mirror @@ -327,8 +327,8 @@ endchoice config MIRROR_MODULES_URL string output yaml - default DEFAULT_MODULES_HTTPS_GIT if MIRROR_MODULES_GIT - default DEFAULT_MODULES_HTTPS_URL if MIRROR_MODULES_HTTPS + default DEFAULT_MODULES_GIT if MIRROR_MODULES_GIT + default DEFAULT_MODULES_HTTPS_GIT if MIRROR_MODULES_HTTPS default DEFAULT_MODULES_HTTPS_GOOGLE_URL if MIRROR_MODULES_HTTPS_GOOGLE choice @@ -407,6 +407,7 @@ endchoice config MIRROR_STABLE_RC_URL string + output yaml default DEFAULT_STABLE_RC_GIT_URL if MIRROR_STABLE_RC_GIT default DEFAULT_STABLE_RC_HTTPS_URL if MIRROR_STABLE_RC_HTTPS default DEFAULT_STABLE_RC_HTTPS_GOOGLE_URL if MIRROR_STABLE_RC_HTTPS_GOOGLE @@ -447,8 +448,8 @@ endchoice config MIRROR_XFS_URL string output yaml - default DEFAULT_XFS_HTTPS_GIT if MIRROR_XFS_GIT - default DEFAULT_XFS_HTTPS_URL if MIRROR_XFS_HTTPS + default DEFAULT_XFS_GIT if MIRROR_XFS_GIT + default DEFAULT_XFS_HTTPS_GIT if MIRROR_XFS_HTTPS default DEFAULT_XFS_HTTPS_GOOGLE_URL if MIRROR_XFS_HTTPS_GOOGLE choice @@ -674,6 +675,7 @@ endchoice config MIRROR_MMTESTS_URL string + output yaml default DEFAULT_MMTESTS_GITHUB_HTTPS_URL if MIRROR_MMTESTS_HTTPS_GITHUB config INSTALL_NIX_CACHE_MIRROR diff --git a/playbooks/roles/linux-mirror/templates/mirrors.yaml.j2 b/playbooks/roles/linux-mirror/templates/mirrors.yaml.j2 index 9f3ee06f..f39d0cb0 100644 --- a/playbooks/roles/linux-mirror/templates/mirrors.yaml.j2 +++ b/playbooks/roles/linux-mirror/templates/mirrors.yaml.j2 @@ -56,7 +56,7 @@ mirrors: url: "{{ defaults_ltp_git }}" target: "ltp.git" - short_name: "mmtests" - url: "{{ defaults_mmtests_git }}" + url: "{{ mirror_mmtests_url }}" target: "mmtests.git" - short_name: "nfstest" url: "{{ defaults_nfstest_git }}" -- 2.51.0