Re: [PATCH v4 1/2] ansible: use native verbosity config instead of custom AV variable

Chuck Lever <[email protected]> Wed, 3 Dec 2025 15:26:04 -0500
Newsgroups dev.linux.lists.kdevops
Message-ID <[email protected]>
On Tue, Dec 02, 2025 at 12:11:16AM +0100, Daniel Gomez wrote:
> From: Daniel Gomez <[email protected]>
> 
> Replace the custom AV makefile variable and validate_av.py script with
> Ansible's native verbosity configuration. The verbosity level is now
> configured via the verbosity key in ansible.cfg, which can be set
> through the new ANSIBLE_CFG_VERBOSITY Kconfig option.
> 
> This change removes the $(ANSIBLE_VERBOSE) variable from all 52
> Makefiles that were passing it to ansible-playbook calls. Since
> ansible.cfg now contains the verbosity setting, the command-line
> argument is no longer needed.
> 
> The runtime override is now done using the standard ANSIBLE_VERBOSITY
> environment variable instead of the custom AV=N syntax.
> 
> Generated-by: Claude AI
> Signed-off-by: Daniel Gomez <[email protected]>

> diff --git a/workflows/mmtests/Makefile b/workflows/mmtests/Makefile
> index c6248b95..712ce70d 100644
> --- a/workflows/mmtests/Makefile
> +++ b/workflows/mmtests/Makefile
> @@ -2,55 +2,55 @@ MMTESTS_ARGS	:=
>  
>  
>  mmtests:
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
> +	$(Q)ansible-playbook \
>  		playbooks/mmtests.yml \
>  		--extra-vars=@./extra_vars.yaml  \
>  		--tags deps,setup
>  		$(MMTESTS_ARGS)
>  

Looks like this target is missing a backslash at the end of
"--tags deps,setup", though that has been missing since
commit 0b829e6a1fb8 ("mmtests: add support for Mel Gorman's
mmtests").

Reviewed-by: Chuck Lever <[email protected]>

-- 
Chuck Lever