[PATCH] libvirt_user: fold Fedora into the RedHat-family enable-user branch
Daniel Gomez <[email protected]> Tue, 19 May 2026 15:44:33 +0200
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> The enable-user dispatcher routes Fedora to enable-user/fedora/main.yml, but that file has never existed in the tree. include_tasks raises a runtime FileNotFoundError on Fedora, so the role is broken there today. The Fedora package-install branch under install-deps/fedora/ is real and carries genuine package differences, but the user-enablement sequence is identical across the RedHat family. Drop the Fedora-only exclusion on the redhat include and the dead Fedora include; one include now covers every RedHat-family distribution. Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- The libvirt_user role's enable-user dispatcher routes Fedora through enable-user/fedora/main.yml, but that file has never existed in the tree. Anyone running the role on a Fedora host hits a runtime FileNotFoundError. This single-patch series folds Fedora into the existing RedHat-family enable-user include, since the user-enablement sequence is identical across the RedHat family. The Fedora-specific package-install branch under install-deps/fedora/ is preserved (it carries genuine differences). This series depends on the "treewide: add SPDX-License-Identifier headers" series. --- playbooks/roles/libvirt_user/tasks/enable-user/main.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml index d5a02885..7eb55881 100644 --- a/playbooks/roles/libvirt_user/tasks/enable-user/main.yml +++ b/playbooks/roles/libvirt_user/tasks/enable-user/main.yml @@ -8,14 +8,6 @@ ansible.builtin.include_tasks: enable-user/suse/main.yml when: ansible_os_family == 'Suse' -- name: Red Hat user enablement +- name: Red Hat family user enablement ansible.builtin.include_tasks: enable-user/redhat/main.yml - when: - - ansible_os_family == 'RedHat' - - ansible_facts['distribution'] != "Fedora" - -- name: Fedora user enablement - ansible.builtin.include_tasks: enable-user/fedora/main.yml - when: - - ansible_os_family == 'RedHat' - - ansible_facts['distribution'] == "Fedora" + when: ansible_os_family == 'RedHat' --- base-commit: 83c7dfdf33f790787972fdc569d0889da853cdb8 change-id: 20260518-b4-libvirt_user-fixes-90ee09a7da3f Best regards, -- Daniel Gomez <[email protected]>