[PATCH v2 0/5] kdevops: fixes for new ansible and some nfsd default config changes

I originally sent these around a month ago. Daniel made some comments
and then I dropped the ball on addressing and merging them. This is v2.
It's basically the same as v1, but with some merge conflict fixups and
Daniel's comments addressed (at least on the target_linux_install_b4
parts). Original cover letter is below:

----------------------------8<------------------------------

ansible-2.20 contains a backward-incompatible change. Strings can no
longer be evaluated as booleans. It throws an exception instead. The
first patch fixes this up in all of the places the tree I could find.

The last patches are more optional, but I've been carrying them for a
while, and it would be nice to get them in. I think they make for
reasonable changes to the existing workflows.

Signed-off-by: Jeff Layton <[email protected]>
---
Changes in v2:
- Remove redundant "is defined" checks for several variables
- Add patch to replace deprecated top-level ansible_* facts with ansible_facts[]
- Rebase onto main and fix up merge conflicts
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Jeff Layton (5):
      ansible: fix bare conditionals for ansible-core 2.20+ strict booleans
      ansible: replace deprecated top-level ansible_* facts with ansible_facts[]
      gitr: enable verbose logging in the test harness
      nfsd: use more reasonable defaults for local VM testing
      devconfig: add some extra packages to the kdev tools

 kconfigs/Kconfig.nfsd                              |   4 +-
 playbooks/build_linux_results.yml                  |   2 +-
 playbooks/fio-tests-multi-fs-compare.yml           |   2 +-
 .../ai_multifs_run/tasks/run_single_filesystem.yml |   2 +-
 playbooks/roles/ai_multifs_setup/tasks/main.yml    |   2 +-
 playbooks/roles/ai_run_benchmarks/tasks/main.yml   |   6 +-
 playbooks/roles/base_image/tasks/base-image.yml    |   8 +-
 .../blktests/tasks/install-deps/suse/main.yml      |  32 +--
 playbooks/roles/blktests/tasks/main.yml            |   2 +-
 playbooks/roles/bootlinux/defaults/main.yml        |   6 +-
 playbooks/roles/bootlinux/tasks/build/9p.yml       |   3 +-
 playbooks/roles/bootlinux/tasks/build/builder.yml  |  21 +-
 playbooks/roles/bootlinux/tasks/build/targets.yml  |   3 +-
 .../roles/bootlinux/tasks/install-deps/main.yml    |   6 +-
 .../bootlinux/tasks/install-deps/redhat/main.yml   |   4 +-
 .../bootlinux/tasks/install-minimal-deps/main.yml  |   6 +-
 .../roles/bootlinux/tasks/install/packages.yml     |   4 +-
 playbooks/roles/bootlinux/tasks/main.yml           |   9 +-
 .../btrfs_progs/tasks/install-deps/suse/main.yml   |   6 +-
 playbooks/roles/build_linux/tasks/main.yml         |  30 +--
 playbooks/roles/codereadyrepo/tasks/main.yml       |  32 +--
 .../roles/create_data_partition/tasks/main.yml     |   2 +-
 playbooks/roles/create_nfs_mount/tasks/main.yml    |   4 +-
 .../tasks/install-deps/redhat/main.yml             |   2 +-
 .../tasks/install-deps/suse/main.yml               |  32 +--
 .../roles/cxl/tasks/install-deps/suse/main.yml     |  32 +--
 playbooks/roles/cxl/tasks/main.yml                 |   2 +-
 playbooks/roles/devconfig/tasks/datacrunch_ml.yml  |  10 +-
 .../roles/devconfig/tasks/install-deps/main.yml    |   8 +-
 .../devconfig/tasks/install-deps/redhat/main.yml   |  18 +-
 .../devconfig/tasks/install-deps/suse/main.yml     |  36 +--
 .../devconfig/tasks/kotd-rev-kernel/suse/main.yml  |  30 +--
 playbooks/roles/devconfig/tasks/main.yml           |  20 +-
 .../roles/dhclient_cache/tasks/isc-dhclient.yml    |   2 +-
 .../roles/dhclient_cache/tasks/networkmanager.yml  |   2 +-
 playbooks/roles/dhclient_cache/tasks/wicked.yml    |   2 +-
 .../tasks/install-deps/debian/main.yml             |   4 +-
 .../docker-mirror/tasks/install-deps/main.yml      |   6 +-
 .../docker-mirror/templates/docker-manifest.txt.j2 |   2 +-
 playbooks/roles/epel-release/tasks/main.yml        |   8 +-
 .../roles/fio-tests/tasks/install-deps/main.yml    |   2 +-
 .../fstests/tasks/install-deps/redhat/main.yml     |   4 +-
 .../roles/fstests/tasks/install-deps/suse/main.yml |  32 +--
 playbooks/roles/fstests/tasks/main.yml             |  11 +-
 .../tasks/install-deps/suse/main.yml               |  28 +--
 playbooks/roles/gen_hosts/tasks/main.yml           |  81 ++++---
 playbooks/roles/gen_nodes/tasks/main.yml           | 256 +++++++++++----------
 playbooks/roles/gen_pci_kconfig/tasks/main.yml     |   4 +-
 playbooks/roles/gen_tfvars/tasks/main.yml          |   6 +-
 playbooks/roles/gitr/tasks/install-deps/main.yml   |  10 +-
 .../roles/gitr/tasks/install-deps/redhat/main.yml  |  12 +-
 playbooks/roles/gitr/tasks/main.yml                |  24 +-
 playbooks/roles/guestfs/tasks/bringup/main.yml     |   2 +-
 .../roles/guestfs/tasks/install-deps/main.yml      |   6 +-
 .../guestfs/tasks/install-deps/redhat/main.yml     |   2 +-
 .../tasks/install-deps/suse/main.yml               |   6 +-
 .../tasks/install-deps/suse/main.yml               |   6 +-
 playbooks/roles/iscsi/tasks/add_initiator.yml      |   4 +-
 playbooks/roles/iscsi/tasks/main.yml               |   4 +-
 playbooks/roles/kdc/tasks/install-deps/main.yml    |   6 +-
 playbooks/roles/kdc/tasks/main.yml                 |  14 +-
 playbooks/roles/kdc/templates/krb5.conf.j2         |   4 +-
 playbooks/roles/kdevops_archive/tasks/main.yml     |   2 +-
 playbooks/roles/krb5/tasks/install-deps/main.yml   |   6 +-
 playbooks/roles/krb5/tasks/main.yml                |  10 +-
 .../roles/ktls/tasks/install-deps/redhat/main.yml  |   2 +-
 playbooks/roles/ktls/tasks/main.yml                |   2 +-
 .../roles/libvirt_user/tasks/enable-user/main.yml  |   7 +-
 .../libvirt_user/tasks/enable-user/redhat/main.yml |   2 +-
 .../libvirt_user/tasks/enable-user/suse/main.yml   |   2 +-
 .../linux-mirror/tasks/install-deps/nfs/main.yml   |   6 +-
 playbooks/roles/linux-mirror/tasks/main.yml        |   8 +-
 playbooks/roles/ltp/tasks/main.yml                 |  10 +-
 playbooks/roles/milvus/tasks/benchmark.yml         |   2 +-
 playbooks/roles/milvus/tasks/install_docker.yml    |   8 +-
 playbooks/roles/minio_install/tasks/main.yml       |   6 +-
 playbooks/roles/minio_warp_run/tasks/main.yml      |  18 +-
 playbooks/roles/mmtests_compare/tasks/main.yml     |   4 +-
 .../roles/monitoring/tasks/install-deps/main.yml   |   4 +-
 .../roles/monitoring/tasks/monitor_collect.yml     |   4 +-
 .../monitoring/tasks/monitor_collect_only.yml      |   6 +-
 .../tasks/monitors/folio_migration/collect.yml     |  14 +-
 .../monitors/folio_migration/collect_only.yml      |   4 +-
 .../roles/nfsd/tasks/install-deps/debian/main.yml  |   4 +-
 .../roles/nfsd/tasks/install-deps/redhat/main.yml  |   6 +-
 .../roles/nfsd/tasks/install-deps/suse/main.yml    |   6 +-
 playbooks/roles/nfsd/tasks/main.yml                |   6 +-
 playbooks/roles/nfsd/templates/nfs.conf.j2         |   5 +
 playbooks/roles/nfstest/tasks/main.yml             |   4 +-
 playbooks/roles/pkg/tasks/debian.yml               |   8 +-
 .../roles/pynfs/tasks/install-deps/debian/main.yml |   2 +-
 .../roles/pynfs/tasks/install-deps/redhat/main.yml |   2 +-
 .../roles/qemu/tasks/install-deps/suse/main.yml    |   3 +-
 .../roles/reboot-limit/tasks/do-reboot-compare.yml |   2 +-
 playbooks/roles/reboot-limit/tasks/do-reboot.yml   |   6 +-
 playbooks/roles/rxe/templates/udev-rule.j2         |   4 +-
 .../selftests/tasks/install-deps/suse/main.yml     |  32 +--
 playbooks/roles/selftests/tasks/main.yml           |   2 +-
 playbooks/roles/siw/templates/udev-rule.j2         |   4 +-
 .../roles/smbd/tasks/install-deps/debian/main.yml  |   4 +-
 playbooks/roles/smbd/tasks/install-deps/main.yml   |   6 +-
 .../roles/smbd/tasks/install-deps/redhat/main.yml  |   4 +-
 .../roles/smbd/tasks/install-deps/suse/main.yml    |   4 +-
 playbooks/roles/smbd/tasks/main.yml                |   6 +-
 playbooks/roles/steady_state/tasks/main.yaml       |   2 +-
 .../sysbench/tasks/install-deps/redhat/main.yml    |   2 +-
 .../sysbench/tasks/install-deps/suse/main.yml      |  32 +--
 .../roles/sysbench/tasks/mysql-docker/main.yaml    |   4 +-
 .../roles/terraform/tasks/bringup/datacrunch.yml   |   6 +-
 playbooks/roles/update_etc_hosts/tasks/main.yml    |  14 +-
 .../roles/vllm/tasks/configure-docker-data.yml     |  10 +-
 playbooks/roles/vllm/tasks/deploy-bare-metal.yml   |   2 +-
 .../roles/vllm/tasks/install-deps/redhat/main.yml  |  16 +-
 playbooks/roles/vllm/tasks/main.yml                |  18 +-
 playbooks/roles/vllm/tasks/setup-kubernetes.yml    |   6 +-
 .../roles/vllm/templates/vllm-visualize.py.j2      |   2 +-
 playbooks/roles/volume_group/tasks/guestfs.yml     |   4 -
 .../roles/volume_group/tasks/terraform/oci.yml     |   2 +-
 118 files changed, 659 insertions(+), 644 deletions(-)
---
base-commit: 0b5567e15c3bceee0b79359e3d524ad08d06beb7
change-id: 20260515-fixes-4e708e81ced8

Best regards,
-- 
Jeff Layton <[email protected]>