Re: [PATCH] net/handshake: duplicate handshake cancellations leak socket
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev |
|---|---|
| Message-ID | <176607061177.3000958.13778061126255337955.git-patchwork-notify@kernel.org> |
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>: On Tue, 9 Dec 2025 14:30:15 -0500 you wrote: > When a handshake request is cancelled it is removed from the > handshake_net->hn_requests list, but it is still present in the > handshake_rhashtbl until it is destroyed. > > If a second cancellation request arrives for the same handshake request, > then remove_pending() will return false... and assuming > HANDSHAKE_F_REQ_COMPLETED isn't set in req->hr_flags, we'll continue > processing through the out_true label, where we put another reference on > the sock and a refcount underflow occurs. > > [...] Here is the summary with links: - net/handshake: duplicate handshake cancellations leak socket https://git.kernel.org/netdev/net/c/15564bd67e29 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html