Re: [PATCH net-next v6 02/16] net: build socket infrastructure for QUIC protocol

Xin Long <[email protected]> Thu, 8 Jan 2026 17:19:49 -0500

Newsgroups	dev.linux.lists.kernel-tls-handshake,dev.linux.lists.quic,org.kernel.vger.linux-cifs,org.kernel.vger.netdev
Message-ID	<CADvbK_eVM5T3u7hiXR=S3ydHCAneCP_wLM7Q4Tc=D6eJ9tv4sA@mail.gmail.com>

On Thu, Jan 8, 2026 at 9:40 AM Paolo Abeni <[email protected]> wrote:
>
> On 1/5/26 3:04 PM, Xin Long wrote:
> > +static int quic_net_proc_init(struct net *net)
> > +{
> > +     quic_net(net)->proc_net = proc_net_mkdir(net, "quic", net->proc_net);
> > +     if (!quic_net(net)->proc_net)
> > +             return -ENOMEM;
> > +
> > +     if (!proc_create_net_single("snmp", 0444, quic_net(net)->proc_net,
> > +                                 quic_snmp_seq_show, NULL))
> > +             goto free;
> > +     return 0;
> > +free:
>
> Minor nits: I think an empty line before the label makes the code more
> readable, and I would prefer #if IS_ENABLED() over #ifdef.
>
Will replace all #ifdefs with #if IS_ENABLED().

Thanks.
> Other than that:
>
> Acked-by: Paolo Abeni <[email protected]>
>