Re: [PATCH v3 1/8] tls: Factor tls_decrypt_async_drain() from recvmsg

Sabrina Dubroca <[email protected]> Mon, 16 Mar 2026 11:13:56 +0100
Newsgroups dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev
Message-ID <abfX5FOJRaIMkjTi@krikkit>
2026-03-11, 21:47:57 -0400, Chuck Lever wrote:
> From: Chuck Lever <[email protected]>
> 
> The recvmsg path pairs tls_decrypt_async_wait() with
> __skb_queue_purge(&ctx->async_hold). Bundling the two into
> tls_decrypt_async_drain() gives later patches a single call for
> async teardown.

I was wondering if tls_decrypt_async_wait() without
__skb_queue_purge() is ever the right thing. Once we've waited for all
pending decryptions, async_hold's job is done, we don't need to keep
all that memory around anymore.

Should we just move recvmsg's __skb_queue_purge() into
tls_decrypt_async_wait()?

-- 
Sabrina