Re: [PATCH PATCH net-next v4 1/8] tls: Factor tls_decrypt_async_drain() from recvmsg
Sabrina Dubroca <[email protected]> Thu, 19 Mar 2026 18:21:03 +0100
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev |
|---|---|
| Message-ID | <abwwf79GJ69X1Wim@krikkit> |
2026-03-17, 11:04:14 -0400, Chuck Lever wrote: > From: Chuck Lever <[email protected]> > > The recvmsg path pairs tls_decrypt_async_wait() with > __skb_queue_purge(&ctx->async_hold). Bundling the two into > tls_decrypt_async_drain() gives later patches a single call > for async teardown. > > The purge is kept separate from tls_decrypt_async_wait() > because other callers (the -EBUSY fallback in > tls_do_decryption and the tls_strp_msg_hold error path) > need to synchronize without discarding held skbs that > are still awaiting delivery. Sorry, but why do we need to keep the encrypted skbs around in the async_hold queue once async decryption has completed? I guess I'm missing something. -- Sabrina