Re: [PATCH v7 4/5] nvme-tcp: Support KeyUpdate
Christoph Hellwig <[email protected]> Fri, 20 Mar 2026 08:51:20 +0100
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.infradead.lists.linux-nvme,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Mar 04, 2026 at 09:37:22PM +1000, Alistair Francis wrote: > > I think a simple 'if' condition would be sufficient here, or do you have > > handling of other TLS record types queued somewhere? > > And we should log unhandled TLS records. > > I like this approach as it makes it really easy to handle more types > in the future. I don't have any more record types queued anywhere so I > can change it to an if statement. Agreed. OTOH having more than a handful of lines in switches like this is a always a bad idea, so factoring this out into a type-specific helper would be much preferred.