Re: [PATCH PATCH net-next v4 2/8] tls: Abort the connection on decrypt failure
Sabrina Dubroca <[email protected]> Mon, 23 Mar 2026 11:22:39 +0100
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev |
|---|---|
| Message-ID | <acEUb-oGmTBJKa9H@krikkit> |
2026-03-17, 11:04:15 -0400, Chuck Lever wrote: > From: Chuck Lever <[email protected]> > > recvmsg, read_sock, and splice_read each open-code a > tls_err_abort() call after tls_rx_one_record() fails. > Move the abort into tls_rx_one_record() so each receive > path shares a single decrypt-and-abort sequence. > > Suggested-by: Sabrina Dubroca <[email protected]> > Reviewed-by: Hannes Reinecke <[email protected]> > Signed-off-by: Chuck Lever <[email protected]> > --- > net/tls/tls_sw.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Sabrina Dubroca <[email protected]> This introduces a minor change in the unexpected case tls_check_pending_rekey() fails (because we won't call tls_err_abort anymore in this case), but I think that's ok. -- Sabrina