Re: [PATCH net-next v5 1/6] tls: Purge async_hold in tls_decrypt_async_wait()
Hannes Reinecke <[email protected]> Thu, 26 Mar 2026 11:32:18 +0100
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 3/24/26 13:53, Chuck Lever wrote: > From: Chuck Lever <[email protected]> > > The async_hold queue pins encrypted input skbs while > the AEAD engine references their scatterlist data. Once > tls_decrypt_async_wait() returns, every AEAD operation > has completed and the engine no longer references those > skbs, so they can be freed unconditionally. > > A subsequent patch adds batch async decryption to > tls_sw_read_sock(), introducing a new call site that > must drain pending AEAD operations and release held > skbs. Move __skb_queue_purge(&ctx->async_hold) into > tls_decrypt_async_wait() so the purge is centralized > and every caller -- recvmsg's drain path, the -EBUSY > fallback in tls_do_decryption(), and the new read_sock > batch path -- releases held skbs on synchronization > without each site managing the purge independently. > > Signed-off-by: Chuck Lever <[email protected]> > --- > net/tls/tls_sw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke <[email protected]> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich