Re: [PATCH net-next v9 3/5] tls: Factor tls_strp_msg_release() from tls_strp_msg_done()
Jakub Kicinski <[email protected]> Sat, 2 May 2026 18:09:01 -0700
| Newsgroups | dev.linux.lists.kernel-tls-handshake,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 29 Apr 2026 17:48:10 -0400 Chuck Lever wrote: > -void tls_strp_msg_done(struct tls_strparser *strp) > +/** > + * tls_strp_msg_release - release the current strparser message > + * @strp: TLS stream parser instance > + * > + * Release the current record without triggering a check for the > + * next record. Callers must invoke tls_strp_check_rcv() before > + * releasing the socket lock, or queued data will stall until > + * the next tls_strp_data_ready() event. > + */ Please respect local style - don't add kdoc on internal functions. This is not exported, just add the "body" of the comment above the function. Kdoc on internal functions is a waste of LOC and it's easy to forget when adding arguments. > +void tls_strp_msg_release(struct tls_strparser *strp) release -> consume In context of TLS we "release" a socket when we unlock it. And we "consume" and skb when we free it. So "consume" matches the semantics better, no?