Re: Clarifying confusion of our variable placement rules caused by cleanup.h

On Sun, Jan 18, 2026 at 11:04:54AM -0500, Steven Rostedt wrote:
> On Sat, 17 Jan 2026 19:23:07 +0300
> Alexey Dobriyan <[email protected]> wrote:
> 
> > Such rules for headers are mostly harmless -- headers are supposed to be
> > idempotent so ordering doesn't matter. But if ordering doesn't matter
> > why have a rule at all?
> 
> As I mentioned, for aesthetic reasons only. If code is easy to look at,
> it's easier to review. Especially for those with OCD ;-)
> 
> > 
> > Duplicate header are trivially caught by tooling.
> > 
> > But such rules aren't useful either -- I've seen that Python IDEs hide
> > import list by default (and probably manage it) because it is not "real"
> > code.
> > 
> > Rules for initializers can be harmful because ordering affects code
> > generation.
> 
> I agree. I still prefer the upside-down x-mas tree approach for
> declaring variables, but obviously if they also get initialized, then
> that trumps aesthetic reasoning.

Alphabetic order.  Works for Kconfig "select" statements.  ;-)

							Thanx, Paul