Re: Clarifying confusion of our variable placement rules caused by cleanup.h

Steven Rostedt <[email protected]> Sun, 18 Jan 2026 16:07:04 -0500
Newsgroups dev.linux.lists.ksummit,org.kernel.vger.linux-kernel
Message-ID <20260118160704.4f7dda8c@robin>
On Sun, 18 Jan 2026 14:17:30 -0500
James Bottomley <[email protected]> wrote:

> How is any of this relevant to a style document?  You're quibbling over
> individual maintainer foibles which, while they may be deeply held to
> you (and obviously are relevant to contributors to your subsystems

Not just me, there are other maintainers that feel this way.

> because they need to know your foibles), can't be part of our universal
> advice because not all maintainers agree (not even on the direction of
> the Christmas Tree).

I don't believe the direction is controversial with variable
declarations. Maybe for header files, in which case, either is fine
with me.

Again, it's mostly due to aesthetics and it's more of a guideline than
a rule (for me). I do know of other maintainers where they are more
strict about it than I am.

-- Steve