Re: How to fix problems with the sashiko review model

On Wed, Jul 22, 2026 at 09:45:48AM -0500, James Bottomley wrote:
> So you're thinking of this file:
> 
> Documentation/process/threat-model.rst
> 
> ?  It's already mostly in there, it's just that sashiko doesn't seem to
> be picking it up (otherwise it wouldn't have suggested the problem I
> noted), which is why I was thinking it needed to be a direct prompt ...
> unless the prompt should be to read that file?

The threat-model.md is relatively new (May 2026), and there are
various security people who have asserted on linux-kernel that we need
to be afraid of malicious hardware.

I'll note that I and other file system developers have asserted that
mounting malicious corrupted file system images is not in our threat
model (and if you want it to be part of the threat model then fund the
engineers; if it doesn't impact performances, patches gratefully
accepted).  And it yet it took **years** to convince the Syzbot
security folks that this was something We Didn't Care About and to
please stop generating the noise.  (And even now, root can modify the
loop device using loop the device ioctls, cause a kernel oops, and
this gets reportred as a security issue.  Sigh...)  So this problem is
not unique to LLM's.  Syzbot and oss-fuzz generates a huge amount of
noise, and I've just learned to ignore it.

The bottom line is that there are differences of opinion of security
people who like to opine that we need to adhere to the most expansive
threat models --- but they don't actually fund the engineering work;
they just like to dump work on the kernel development community.  And
that opinion has probably infected Sashiko's training data.

The approach is probably to adjust Sashiko's prompts to have it
explicitly read our threat model, and to have that take precedence
over its training data.

Cheers,

						- Ted