Re: How to fix problems with the sashiko review model
Miguel Ojeda <[email protected]> Wed, 22 Jul 2026 17:29:03 +0200
| Newsgroups | dev.linux.lists.ksummit,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-scsi |
|---|---|
| Message-ID | <CANiq72m4XJcj+y-VnWYBwoMvJd+P8Xqs2dK3vaGEycFpqwAt_g@mail.gmail.com> |
On Wed, Jul 22, 2026 at 4:15=E2=80=AFPM James Bottomley <[email protected]> wrote: > > So you're thinking of this file: > > Documentation/process/threat-model.rst > > ? It's already mostly in there, it's just that sashiko doesn't seem to > be picking it up (otherwise it wouldn't have suggested the problem I > noted), which is why I was thinking it needed to be a direct prompt ... > unless the prompt should be to read that file? Yeah, I had the same question for the Rust subsystem -- I have some guidelines I want to add, which should be useful for both humans and LLMs (e.g. not too many tokens), but I am not sure what is the best practice here. I think mentioning it in the prompt is needed, but perhaps it is best to force it into the prompt `#includ`ing it somehow (ideally without actually copy-pasting it every once in a while). Either way, it would be nice to be consistent about this across subsystems both on the kernel and on the prompts repository. Cheers, Miguel