Re: [PATCH 15/20] KVM: arm64: Add pkvm_hyp_req infrastructure

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new exception type ARM_EXCEPTION_PKVM_HYP_REQ is not added to the perf tooling's exception types array.
--

--- Patch [15]: [PATCH 15/20] KVM: arm64: Add pkvm_hyp_req infrastructure ---
commit 1c1513703a277d8ea203bc42984c3485444883e4
Author: Vincent Donnefort <[email protected]>
KVM: arm64: Add pkvm_hyp_req infrastructure

The pKVM hypervisor depends on the host for operations like memory
allocation. This commit introduces struct pkvm_hyp_req and a new
exception type to enable the hypervisor to request resources.

> diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h
> index 37c5e22fac988..00ba99c858741 100644
> --- a/arch/arm64/include/asm/kvm_asm.h
> +++ b/arch/arm64/include/asm/kvm_asm.h
[ ... ]
> @@ -28,6 +29,7 @@
>  	{ARM_EXCEPTION_IRQ,		"IRQ"		},	\
>  	{ARM_EXCEPTION_EL1_SERROR, 	"SERROR"	},	\
>  	{ARM_EXCEPTION_TRAP, 		"TRAP"		},	\
> +	{ARM_EXCEPTION_PKVM_HYP_REQ,	"PKVM_HYP_REQ"	},	\

[Severity: Medium]
Does the perf tool need to be updated to recognize this new exception
type?

The perf tool maintains a mirror of the exception types for decoding
KVM exit reasons:

tools/perf/util/kvm-stat-arch/arm64_exception_types.h:
#define kvm_arm_exception_type                                  \
	{ARM_EXCEPTION_IRQ,             "IRQ"           },      \
	{ARM_EXCEPTION_EL1_SERROR,      "SERROR"        },      \
	{ARM_EXCEPTION_TRAP,            "TRAP"          },      \
	{ARM_EXCEPTION_IL,              "ILLEGAL"       },      \
	{ARM_EXCEPTION_HYP_GONE,        "HYP_GONE"      }

Without adding ARM_EXCEPTION_PKVM_HYP_REQ to this array, will
perf kvm stat fail to parse and display this new exit reason correctly
when profiling a pKVM host?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=15