Re: [PATCH v16 11/45] KVM: arm64: CCA: Check for RMI support at KVM init

Suzuki K Poulose <[email protected]> Tue, 4 Aug 2026 15:59:11 +0100

Newsgroups	dev.linux.lists.kvmarm,dev.linux.lists.linux-coco,org.infradead.lists.linux-arm-kernel,org.kernel.vger.kvm,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 04/08/2026 15:55, Fuad Tabba wrote:
> Hi Steven,
> 
> On Mon, 3 Aug 2026 at 14:45, Steven Price <[email protected]> wrote:
> ...
>> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
>> index bae2c4f92ef5..1a5e15040111 100644
>> --- a/arch/arm64/include/asm/kvm_host.h
>> +++ b/arch/arm64/include/asm/kvm_host.h
>> @@ -27,6 +27,7 @@
>>   #include <asm/fpsimd.h>
>>   #include <asm/kvm.h>
>>   #include <asm/kvm_asm.h>
>> +#include <asm/kvm_rmi.h>
>>   #include <asm/vncr_mapping.h>
>>
>>   #define __KVM_HAVE_ARCH_INTC_INITIALIZED
>> @@ -424,6 +425,9 @@ struct kvm_arch {
>>          /* Nested virtualization info */
>>          struct dentry *debugfs_nv_dentry;
>>   #endif
>> +
>> +       bool is_realm;
>> +       struct realm realm;
>>   };
> 
> Marc suggested at v10 making the pKVM and CCA state here a union,
> given the two are exclusive, and I believe you acked it [1]. Was there
> an issue with it, or did it just get lost across the respins?

Most likely lost in the respins. Will pick this up.

Thanks for spotting.

Cheers
Suzuki