Re: [PATCH v6 24/33] KVM: s390: Use arm64 code

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Potential Makefile syntax error due to an incorrectly named variable `kvm-arm64-obj`.
--

--- Patch [24]: [PATCH v6 24/33] KVM: s390: Use arm64 code ---
commit e4207bffe34b1de1b2b51c1d13254c153e76c1b6
Author: Steffen Eiden <[email protected]>

KVM: s390: Use arm64 code

This commit adds the infrastructure to extract KVM/arm64 code into s390 at build
time. It introduces an awk script to extract marked sections into .inc files
and a Makefile.gen to generate these dependencies. A guard macro is also
included in the generated files to prevent accidental double consumption.

> diff --git a/arch/s390/kvm/arm64/Makefile.gen b/arch/s390/kvm/arm64/Makefile.gen
> new file mode 100644
> index 0000000000000..cb9482eb947b9
> --- /dev/null
> +++ b/arch/s390/kvm/arm64/Makefile.gen
> @@ -0,0 +1,29 @@
[ ... ]
> +ARM64_INC_FILES := $(foreach cfile,$(ARM64_CFILES),generated/$(basename $(cfile)).inc)
> +
> +targets += $(ARM64_INC_FILES)
> +clean-files += generated/*.inc
> +
> +$(addprefix $(obj)/,$(kvm-arm64-obj)): $(addprefix $(obj)/,$(ARM64_INC_FILES))
                        ^^^^^^^^^^^^^

[Severity: Low]
Will this result in a fatal make syntax error if the Makefile is included?

The variable kvm-arm64-obj is used here to declare dependencies, but it does
not appear to be defined anywhere in the tree. If this evaluates to an empty
string, the addprefix function will return empty on the left side of the
colon, breaking make with a missing rule before recipe error.

Should this variable be defined before use, or was a different variable name
intended?

> +
> +$(foreach cfile,$(basename $(ARM64_CFILES)),\
> +	$(eval $(obj)/$(cfile).o: $(obj)/generated/$(cfile).inc))

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=24