Re: [PATCH v16 00/45] arm64: Support for Arm CCA in KVM
Steven Price <[email protected]> Mon, 3 Aug 2026 16:45:25 +0100
| Newsgroups | dev.linux.lists.linux-coco,dev.linux.lists.kvmarm,org.infradead.lists.linux-arm-kernel,org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 03/08/2026 16:20, Marc Zyngier wrote: > On Mon, 03 Aug 2026 16:06:24 +0100, > Steven Price <[email protected]> wrote: >> >> On 03/08/2026 16:01, Marc Zyngier wrote: >>> On Mon, 03 Aug 2026 14:43:16 +0100, >>> Steven Price <[email protected]> wrote: >>>> >>>> This series is based on the guest_memfd in-place conversion v9 tree[1], >>>> which is itself based on kvm-x86/next. It is also available as a git >>>> repository: >>> >>> Well done. Series on top of another random series, based on a random >>> tree. Unusable. Have you realised there are reasons why we (KVM/arm64) >>> ask people to base their series on a *released* tag from Linus' tree? >>> This means that Sashiko cannot, once again, provide any feedback on >>> this series, as it fails to apply. >>> >>> Just to avoid any ambiguity: Sashiko reviews, as annoying as they are, >>> are not optional. They are very much mandatory, and I wish I could >>> turn back the clocks to run it on my own code... >>> >>> Running it on your own is not enough, because *I* want to see what the >>> tool finds. Not to mention that non-Gemini runs of sashiko are much >>> less interesting (unsurprisingly). >> >> Sorry, but I'm not sure what you expect me to do - clearly I want to >> base my changes on top of the guest_memfd series which is being worked >> on and not just ignore that work. So I've based my changes on top of the >> tree that Ackerley published. > > But that completely ignores the way the KVM/arm64 tree is managed. If > you base a series on a bunch of unmerged patches, how do you expect > people to do a sensible job at reviewing it? Now I need to ingest > another pile of random patches just to review this set? It's based on the same 'base' as v15 was - it depends on the unmerged guest_memfd changes. I've just updated to the latest revision from Ackerley. You've been reviewing the changes, and I've attempted to update the code based on that valuable feedback. Clearly I'm not expecting this series to be merged yet - we're waiting for the guest_memfd changes. If you have a suggestion on how I should tackle this in the future then please let me know. I could bombard you with an even bigger series with Ackerley's series on the front, but I think you'd shout at me even more if I did that. > Not happening, sorry. Well I'm off on 'holiday' or more accurately to move house. The new house's (brand new) hot water cylinder is bust and the plumber is currently saying we can't even have cold water, never mind hot, so I'm going to spend the next week worrying about things other than this series. If you provide review comments then I'll look at them when I get back. Thanks, Steve