Re: [PATCH] staging: rtl8723bs: fix unnamed parameters warning detected at checkpatch

On Tue, Apr 07, 2026 at 10:27:21AM -0300, Rodrigo Gobbi wrote:
> Detected the following WARNING: function definition argument
> 'struct adapter *' should also have an identifier name.
> Add explicit names on those definitions.
> 
> Signed-off-by: Rodrigo Gobbi <[email protected]>
> ---
> Hi, all,
> 
> Found a set of these warnings with checkpatch:
> 
> drivers/staging/rtl8723bs/include/hal_btcoex.h:25: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/hal_btcoex.h:49: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/hal_btcoex.h:50: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/hal_btcoex.h:51: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/hal_intf.h:255: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_btcoex.h:18: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_btcoex.h:19: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_btcoex.h:24: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_btcoex.h:25: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_btcoex.h:26: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:218: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:219: WARNING: function definition argument 'struct adapter *' should also have an identifier name
> 
> ...the ones from hal_btcoex.h is already ongoing at [1].
> Fixed the rest of them following the pattern of each file like:
> 
> struct adapter *padapter
> or 
> struct adapter *adapter
> 
> Tks and regards.
> 
> [1] https://lore.kernel.org/all/[email protected]/
> ---
>  drivers/staging/rtl8723bs/include/hal_intf.h    |  2 +-
>  drivers/staging/rtl8723bs/include/rtw_btcoex.h  | 10 +++++-----
>  drivers/staging/rtl8723bs/include/rtw_pwrctrl.h |  4 ++--
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
> index b193854bfe6e..10762ffbafb6 100644
> --- a/drivers/staging/rtl8723bs/include/hal_intf.h
> +++ b/drivers/staging/rtl8723bs/include/hal_intf.h
> @@ -252,7 +252,7 @@ c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter);
>  s32 rtw_hal_macid_sleep(struct adapter *padapter, u32 macid);
>  s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32 macid);
>  
> -s32 rtw_hal_fill_h2c_cmd(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer);
> +s32 rtw_hal_fill_h2c_cmd(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer);

No need to give variable names you will have to later fix up, just call
it "adapter", not "padapter" as that's not the kernel coding style.

thanks,

greg k-h