Re: [PATCH] staging: fbtft: Use %pe format specifier for error pointers
Dan Carpenter <[email protected]>
| Newsgroups | dev.linux.lists.linux-kernel-mentees,dev.linux.lists.linux-staging,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Apr 13, 2026 at 10:03:58AM +0300, Andy Shevchenko wrote: > On Sun, Apr 12, 2026 at 5:46 PM Mahad Ibrahim > <[email protected]> wrote: > > > > The %pe format specifier resolves error pointers to their symbolic > > representation. Previously %ld with PTR_ERR() was being used, %pe is a > > better alternative. > > > > Fixes the following coccinelle warnings reported by coccicheck: > > WARNING: Consider using %pe to print PTR_ERR() > > > > Testing: I do not own the hardware, therefore I could not perform > > hardware testing. Compile tested only. > > I don't think it makes any difference for this driver. But I am not > objecting to the change. Up to Greg if he wants to apply or not. I always like these changes. I wish that there were an equivalent %e which printed error codes that weren't stored in an error pointer. KTODO: introduce a %e type format thing which prints error codes regards, dan carpenter