Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init()
Amirreza Zarrabi <[email protected]>
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.trustedfirmware.lists.op-tee |
|---|---|
| Message-ID | <[email protected]> |
Hi,
On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote:
> qcomtee_object_user_init() is a variadic function and when the function
> return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB
> case, there's no va_end to cleanup "ap" object initialized by va_start
> and that can cause undefined behavior. So make sure to use va_end before
> returning the error code when there's no dispatch callback.
>
> This is reported by Coverity Scan as "Missing varargs init or cleanup".
>
> Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver")
> Signed-off-by: Robertus Diawan Chris <[email protected]>
> ---
> I don't have the device, so I am not sure how to test this change.
> Thank you.
>
> drivers/tee/qcomtee/core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c
> index b1cb50e434f0..901a31e8201f 100644
> --- a/drivers/tee/qcomtee/core.c
> +++ b/drivers/tee/qcomtee/core.c
> @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object,
> break;
> case QCOMTEE_OBJECT_TYPE_CB:
> object->ops = ops;
> - if (!object->ops->dispatch)
> - return -EINVAL;
> + if (!object->ops->dispatch) {
> + ret = -EINVAL;
> + goto out;
> + }
>
> /* If failed, "no-name". */
> object->name = kvasprintf_const(GFP_KERNEL, fmt, ap);
> @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object,
> default:
> ret = -EINVAL;
> }
> +
> +out:
> va_end(ap);
>
> return ret;
>
> base-commit: 5d6919055dec134de3c40167a490f33c74c12581
Reviewed-by: Amirreza Zarrabi <[email protected]>
Thanks.
Amir