Re: [PATCH] dt-bindings: leds: bcm6358: Convert to DT schema

Conor Dooley <[email protected]> Mon, 1 Jun 2026 21:20:17 +0100

Newsgroups	dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds
Message-ID	<20260601-recall-reprocess-6608ba60e0cb@spud>

On Sun, May 31, 2026 at 12:45:00AM +0530, Ninad Naik wrote:
> >
> > > +patternProperties:
> > > +  "^led@(0|1?[0-9a-f])$":
> > > +    type: object
> > > +    $ref: common.yaml#
> > > +    description: Each LED is represented as a sub-node of
> > > +      this device.
> > > +
> > > +    properties:
> > > +      reg:
> > > +        description: LED pin number.
> > > +        minimum: 0
> > > +        maximum: 31
> >
> > Is this missing a maxItems: 1?
> >
> Thanks Conor for pointing this out. I will include it in v2.
> 
> >
> > > +
> > > +    required:
> > > +      - reg
> > > +
> > > +    unevaluatedProperties: false
> >
> > I wonder if this should be additionalProperties: false instead, and list
> > the three properties mentioned by the text binding explicitly?
> >
> >
> > Cheers,
> > Conor.
> >
> I added unevaluatedProperties: false because my understanding was
> that explicitly listing the properties inherited from common.yaml would
> be redundant.
> I'd be interested to hear the maintainers' preference here, and can
> adjust this in v2 if needed.

If only those 3 are permitted, it's probably the better approach.

signature.asc (application/pgp-signature, 228 B)