Re: [PATCH v3 4/8] iio: tcs3472: use ! instead of explicit NULL check
Andy Shevchenko <[email protected]> Thu, 4 Jun 2026 11:31:39 +0300
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, May 22, 2026 at 02:34:15PM +0200, Aldo Conte wrote: > Replace 'if (indio_dev == NULL)' with 'if (!indio_dev)' in > tcs3472_probe() to follow the preferred kernel style. > Suggested-by: Joshua Crofts <[email protected]> Joshua, even if it's not written in the documentation (or unclear) the idea is that whoever formally suggested the change has to acknowledge it (Acked-by is enough, but full review is superior, of course). Reviewed-by: Andy Shevchenko <[email protected]> -- With Best Regards, Andy Shevchenko