Re: [PATCH v3 4/8] iio: tcs3472: use ! instead of explicit NULL check
Jonathan Cameron <[email protected]> Thu, 4 Jun 2026 11:37:43 +0100
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260604113743.1231ccfe@jic23-huawei> |
On Thu, 4 Jun 2026 10:38:18 +0200 Joshua Crofts <[email protected]> wrote: > On Thu, 4 Jun 2026 at 10:31, Andy Shevchenko > <[email protected]> wrote: > > > > On Fri, May 22, 2026 at 02:34:15PM +0200, Aldo Conte wrote: > > > Replace 'if (indio_dev == NULL)' with 'if (!indio_dev)' in > > > tcs3472_probe() to follow the preferred kernel style. > > > > > Suggested-by: Joshua Crofts <[email protected]> > > > > Joshua, even if it's not written in the documentation (or unclear) the idea is > > that whoever formally suggested the change has to acknowledge it (Acked-by is > > enough, but full review is superior, of course). > > I see, thanks for the heads up. Not sure if Jonathan will add my tag > at this point, > nevertheless > > Reviewed-by: Joshua Crofts <[email protected]> > This is burried under a merge so indeed unlikely I'll add tags. Still good to have a record on the list for anyone who looks back. I rushed things a bit because today is more or less the cut off for anything making this cycle. Thanks, Jonathan