Re: [PATCH v2] dt-bindings: leds: bcm6358: Convert to DT schema

On Tue, Jun 09, 2026 at 11:47:01PM +0530, Ninad Naik wrote:
> +maintainers:
> +  - Álvaro Fernández Rojas <[email protected]>
> +
> +properties:
> +  compatible:
> +    const: brcm,bcm6358-leds
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  brcm,clk-div:
> +    description: SCK signal divider.
> +    default: 1
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8]
> +
> +  brcm,clk-dat-low:
> +    description: Makes clock and data signals active low.
> +    type: boolean
> +
> +patternProperties:
> +  "^led@(0|1?[0-9a-f])$":

"0" is already in "[0-9a-f]".

> +    type: object
> +    $ref: common.yaml#
> +    description: Each LED is represented as a sub-node of
> +      this device.
> +
> +    properties:
> +      reg:
> +        description: LED pin number (0 to 31).
> +        maxItems: 1
> +
> +      label: true
> +
> +      default-state: true
> +
> +      linux,default-trigger: true
> +
> +      active-low: true

Drop all four above and switch to unevaluatedProperties: false.
unevaluatedProperties should be also placed after $ref: common.yaml for
example.


> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false


Best regards,
Krzysztof