Re: [PATCH v2] md/raid5-ppl: fix use-after-free in ppl_do_flush()
"Brigham Campbell" <[email protected]> Tue, 23 Jun 2026 22:42:47 -0600
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-kernel,org.kernel.vger.linux-raid |
|---|---|
| Message-ID | <[email protected]> |
On Mon Jun 22, 2026 at 8:06 AM MDT, Sajal Gupta wrote: > Compile tested only. It looks like you're on the right track, but this could use some testing. My analysis here may be incorrect, but it looks like it should be pretty easy to test this patch by compiling and running on a system with a RAID5 array, PPL enabled, and no RAID journal. I expect the call stack would look something like the following (feel free to correct me, anyone...): ppl_do_flush ppl_stripe_write_finished log_stripe_write_finished handle_stripe ... To be sure, you can add a tracepoint[^1] inside ppl_do_flush. Dan was probably reluctant to make the change himself, opting to instead submit a KTODO because the change is relatively straightforward, but testing is a little more involved. Testing is particularly important with respect to subsystems pertaining to the filesystem because latent regressions could mean permanent data loss. Cheers, Brigham [1]: https://docs.kernel.org/trace/tracepoints.html