Re: [PATCH v3] tracing: Use seq_buf for string concatenation
Markus Elfring <[email protected]> Wed, 24 Jun 2026 09:15:22 +0200
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-hardening,org.kernel.vger.linux-kernel,org.kernel.vger.linux-trace-kernel |
|---|---|
| Message-ID | <[email protected]> |
…
> +++ b/kernel/trace/trace_events.c
…
> @@ -4501,13 +4502,20 @@ extern struct trace_event_call *__start_ftrace_events[];
…
> static __init int setup_trace_event(char *str)
> {
> - if (bootup_event_buf[0] != '\0')
> - strlcat(bootup_event_buf, ",", COMMAND_LINE_SIZE);
> + if (seq_buf_used(&bootup_event_seq) > 0)
> + seq_buf_puts(&bootup_event_seq, ",");
…
I suggest to use the function “seq_buf_putc” instead at this source code place.
https://elixir.bootlin.com/linux/v7.1.1/source/lib/seq_buf.c#L203-L221
Is there a need for corresponding error detection?
Regards,
Markus