Re: [PATCH v3] media: hantro: release runtime resources when device_run fails
Tharit Tangkijwanichakul <[email protected]> Tue, 28 Jul 2026 11:30:38 +0700
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <CACak8wPnkMz4xgx-BLc4sAeMi01tw3XEBXoZn0B6numhRbFw4Q@mail.gmail.com> |
> You need convert to model RUMTIME_PM_OPS and SYSTEM_SLEEP_PM_OPS > > pm_ptr(hantro_pm_ops) at below hantro_driver > > and remove CONFIG_PM first, > > then add move clock manage into runtime pm management > > If you remove "CONFIG_PM" here, cause build error at some special config. > > Or keep CONFIG_PM at this patch, then convert to RUMTIME_PM_OPS() in > following patch. > > Frank I see, the compiler may flag resume/suspend callback unused if CONFIG_PM=n and cause build error. Thanks for pointing this out. I will keep CONFIG_PM and send a conversion in a subsequent patch. Best, Tharit