Re: [PATCH v3] dt-bindings: leds: lacie,ns2-leds: Convert to DT schema
Krzysztof Kozlowski <[email protected]> Tue, 28 Jul 2026 11:57:35 +0200
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds |
|---|---|
| Message-ID | <[email protected]> |
On 28/07/2026 10:37, Ninad Naik wrote: > > On 28/07/26 1:24 pm, Krzysztof Kozlowski wrote: >> On Fri, Jul 24, 2026 at 09:53:32PM +0530, Ninad Naik wrote: >>> Convert lacie,ns2-leds to DT schema. >>> >>> Reported-by: kernel test robot <[email protected]> >>> Closes: https://lore.kernel.org/r/[email protected]/ >> Drop both. You need to read that report again. > Sorry, I missed the line which says not to include the tags in a new > version of the same patch. Will remove. >> >>> Signed-off-by: Ninad Naik <[email protected]> >>> --- >>> Changes in v3: >>> - Add optional property num-modes to the schema. >> Missing rest of the changelog. >> >> What happened here? >> >> Rest looks good, so with dropping incorrect tags (really, please read >> the email you received): >> >> Reviewed-by: Krzysztof Kozlowski <[email protected]> > Should I carry over this tag in v4? Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here ('b4 trailers -u ...'). However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Full context and explanation: https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591 Best regards, Krzysztof