[PATCH] iio: humidity: htu21: Fix SYMBOLIC_PERMS chekcpatch warning
Adi Nata <[email protected]> Sun, 2 Aug 2026 09:23:26 +0800
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Checkpatch warning: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static IIO_DEVICE_ATTR(battery_low, S_IRUGO, WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. +static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR, Signed-off-by: Adi Nata <[email protected]> --- drivers/iio/humidity/htu21.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/humidity/htu21.c b/drivers/iio/humidity/htu21.c index a9dbf08b4f1a..fe7192d142ec 100644 --- a/drivers/iio/humidity/htu21.c +++ b/drivers/iio/humidity/htu21.c @@ -154,9 +154,9 @@ static ssize_t htu21_write_heater(struct device *dev, } static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(htu21_show_samp_freq); -static IIO_DEVICE_ATTR(battery_low, S_IRUGO, +static IIO_DEVICE_ATTR(battery_low, 0444, htu21_show_battery_low, NULL, 0); -static IIO_DEVICE_ATTR(heater_enable, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(heater_enable, 0644, htu21_show_heater, htu21_write_heater, 0); static struct attribute *htu21_attributes[] = { -- 2.47.3