Re: [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed

--iuutzrwryo4oodb7
Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer
 __packed
MIME-Version: 1.0

Hello,

Just a few nitpicks. These might not justify a v3, as Jonathan sometimes
fixes up such thing while applying.

On Sun, Aug 02, 2026 at 10:51:31AM +0800, Adi Nata wrote:
> Change instance of __attribute__((__packed__)) to __packed per checkpatch=
=2Epl warning
>=20
> Reported by checkpatch:
> FILE: drivers/iio/chemical/sgp30.c
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
>=20
> Signed-off-by: Adi Nata <[email protected]>
>=20
> Reviewed-by: Joshua Crofts <[email protected]>

No empty lines in the S-o-B block, and please put your S-o-b last.

> v2:
> - Rename commit title and message

the v2 changelog belongs after the tripple dash.

>=20
> ---
>  drivers/iio/chemical/sgp30.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
> index f10bbebc29e4..c33592a1e0c9 100644
> --- a/drivers/iio/chemical/sgp30.c
> +++ b/drivers/iio/chemical/sgp30.c
> @@ -82,7 +82,7 @@ struct sgp_version {
>  struct sgp_crc_word {
>  	__be16 value;
>  	u8 crc8;
> -} __attribute__((__packed__));
> +} __packed;

Otherwise looks fine.

Acked-by: Uwe Kleine-K=F6nig <[email protected]>

Best regards
Uwe

--iuutzrwryo4oodb7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpvOXAACgkQj4D7WH0S
/k5YpwgAl/E+S+82lzHQ1buNKpj92C7t4FN2ORPHv2CUxBCnjgUiDAg7aQWJEBEm
HHxz/flAmenUrr+lV7PLfgcLp+6Z6E84YMM2CsQzOHFsztq5hUmcbY7tCqODVFtL
27rWHNjLNtCYepmQG2Z977p9wDKdqOGiBrwft7jytd/f0qXlRhyy7SGiQWabB7zL
4eI7o4FsBxQYdeBSwI7vIsh6LOtprlKBT6oFPlJ/7okrfju2XZqCbU2GDSaqAAj5
gQjbpUUIDqmeumS0IbZrAMfw93Xyrtfe7kwLrD7Aqif69GTKdrCw1bg+smmp+YQy
NkMBPH7XI//6HPe8KOZxxyiznuImlA==
=cjtv
-----END PGP SIGNATURE-----

--iuutzrwryo4oodb7--