Re: [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed

On Sun, 2 Aug 2026 14:34:59 +0200
Uwe Kleine-K=C3=B6nig <[email protected]> wrote:

> Hello,
>=20
> Just a few nitpicks. These might not justify a v3, as Jonathan sometimes
> fixes up such thing while applying.

There are enough things across various patches from Adi that I'd like
new versions incorporating all the various bits of feedback.

But wait a few days first in case there is more to come from additional
reviewers!

Thanks,

Jonathan

>=20
> On Sun, Aug 02, 2026 at 10:51:31AM +0800, Adi Nata wrote:
> > Change instance of __attribute__((__packed__)) to __packed per checkpat=
ch.pl warning
> >=20
> > Reported by checkpatch:
> > FILE: drivers/iio/chemical/sgp30.c
> > WARNING: Prefer __packed over __attribute__((__packed__))
> > +} __attribute__((__packed__));
> >=20
> > Signed-off-by: Adi Nata <[email protected]>
> >=20
> > Reviewed-by: Joshua Crofts <[email protected]> =20
>=20
> No empty lines in the S-o-B block, and please put your S-o-b last.
>=20
> > v2:
> > - Rename commit title and message =20
>=20
> the v2 changelog belongs after the tripple dash.
>=20
> >=20
> > ---
> >  drivers/iio/chemical/sgp30.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
> > index f10bbebc29e4..c33592a1e0c9 100644
> > --- a/drivers/iio/chemical/sgp30.c
> > +++ b/drivers/iio/chemical/sgp30.c
> > @@ -82,7 +82,7 @@ struct sgp_version {
> >  struct sgp_crc_word {
> >  	__be16 value;
> >  	u8 crc8;
> > -} __attribute__((__packed__));
> > +} __packed; =20
>=20
> Otherwise looks fine.
>=20
> Acked-by: Uwe Kleine-K=C3=B6nig <[email protected]>
>=20
> Best regards
> Uwe